-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(fluent-bit): set system-node-critical as a default priorityClass #70
base: main
Are you sure you want to change the base?
feat(fluent-bit): set system-node-critical as a default priorityClass #70
Conversation
25fd497
to
c3ed667
Compare
c3ed667
to
b4cef35
Compare
@lisguo may I ask for a review? |
cd671cc
to
e54cc5a
Compare
e54cc5a
to
043f598
Compare
@lisguo May I ask for a review again? The Integration tests are failing due to |
@m00lecule we should also add the priorityClass to the cloudwatch-agent? https://github.com/aws-observability/helm-charts/blob/main/charts/amazon-cloudwatch-observability/templates/linux/cloudwatch-agent-daemonset.yaml#L23 |
@markandersontrocme I believe so, the general principle is to ensure that monitoring agents are running on all EKS nodes |
I fee like it would make sense to add that to this PR 🙏 |
Issues:
#54
In Kubernetes there is a good practice to specify a
system-node-critical
priority class for monitoring agents running as daemonsets.ref: https://kubernetes.io/docs/tasks/administer-cluster/guaranteed-scheduling-critical-addon-pods/
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.