Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fluent-bit): set system-node-critical as a default priorityClass #70

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

m00lecule
Copy link
Contributor

Issues:
#54

In Kubernetes there is a good practice to specify a system-node-critical priority class for monitoring agents running as daemonsets.

ref: https://kubernetes.io/docs/tasks/administer-cluster/guaranteed-scheduling-critical-addon-pods/

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@m00lecule m00lecule force-pushed the feat-priority-class-support branch 3 times, most recently from 25fd497 to c3ed667 Compare July 25, 2024 19:13
@m00lecule m00lecule force-pushed the feat-priority-class-support branch from c3ed667 to b4cef35 Compare July 25, 2024 19:13
@m00lecule
Copy link
Contributor Author

@lisguo may I ask for a review?

@m00lecule m00lecule changed the title feat(fluent-bit): set system-node-critical as default priorityClass feat(fluent-bit): set system-node-critical as a default priorityClass Jul 25, 2024
@m00lecule
Copy link
Contributor Author

@lisguo May I ask for a review again? The Integration tests are failing due to Error: Credentials could not be loaded, please check your action inputs: Could not load credentials from any providers which doesn't seem to be connected with my changes.

@markandersontrocme
Copy link

@m00lecule we should also add the priorityClass to the cloudwatch-agent? https://github.com/aws-observability/helm-charts/blob/main/charts/amazon-cloudwatch-observability/templates/linux/cloudwatch-agent-daemonset.yaml#L23

@m00lecule
Copy link
Contributor Author

@m00lecule we should also add the priorityClass to the cloudwatch-agent? https://github.com/aws-observability/helm-charts/blob/main/charts/amazon-cloudwatch-observability/templates/linux/cloudwatch-agent-daemonset.yaml#L23

@markandersontrocme I believe so, the general principle is to ensure that monitoring agents are running on all EKS nodes

@markandersontrocme
Copy link

@markandersontrocme I believe so, the general principle is to ensure that monitoring agents are running on all EKS nodes

I fee like it would make sense to add that to this PR 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants