Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Replace CodeCommit usage with s3 #7

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

janpreusss
Copy link
Contributor

As code commit is deprecated we need another solution to allow the functionality and maintain a solution where everything is kept internally. As replacement for code commit this change replaces the usage of git with S3 calls.
The corresponding AMI changes are required to have the same over in these definitions.

Description of changes:

  • Overall code clean-up
  • Remove unused models and classes
  • Remove instance auto scaling policy
  • Fix worker and SF with RemovalPolicy and updated NiceDCV AMIs
  • Update documentation
  • Persist workbench to allow restarts
  • Updated AMI ID to reflect recent changes

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@janpreusss janpreusss changed the title Replace CodeCommit usage with s3 fix replace CodeCommit usage with s3 Aug 23, 2024
@janpreusss janpreusss changed the title fix replace CodeCommit usage with s3 fix: Replace CodeCommit usage with s3 Aug 23, 2024
- Overall code cleanup
- Remove unused models and classes
- Remove instance auto scaling policy
- Fix worker and SF with RemovalPolicy and updated NiceDCV AMIs
- Update documentation
- Persist workbench to allow restarts
- Updated AMI ID to reflect recent changes
@olivier-sutter olivier-sutter merged commit 5d84f53 into aws-samples:main Aug 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants