Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Serverless Pattern - Amazon EventBridge pipe - filter and transform using cdk python #2043

Conversation

manikandanks2000
Copy link
Contributor

Issue #, if available:

Description of changes:
This pattern will use Amazon EventBridge Pipe to accept source messages from Amazon Simple Queue Service and will apply filter and transformation before sending the target message to AWS Step Functions.
This example project implemented with CDK/Python.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@manikandanks2000
Copy link
Contributor Author

This branch is based on closed branch
#1994
for some reason that branch was picking files outside my changes and was not able to remove them, hence decided to create new one to avoid issues. thanks for your support

manikandanks2000 and others added 10 commits January 16, 2024 14:57
@manikandanks2000
Copy link
Contributor Author

@bfreiberg thanks for the inputs . I have accepted the recommendations and changes to the source.

@bfreiberg
Copy link
Contributor

Thank you for the updates. Could you please remove the __pycache__ folder.

…ern-eventbridge-pipe-sqs-stepfunctions-filter-transform-cdk-python
…thon/cdk_eventbridge_pipes_sqs_to_stepfunctions_python/__pycache__ directory

delete pycache cache directory
…thon/cdk_eventbridge_pipes_sqs_to_stepfunctions_python/__init__.py

remove the _init_.py file.
@manikandanks2000
Copy link
Contributor Author

Thank you for the updates. Could you please remove the __pycache__ folder.

Sure. I have deleted it now.

@bfreiberg
Copy link
Contributor

Please use the correct folder name in your example.json and please use a shorter folder name for your CDK code as well, like cdk for example.

@manikandanks2000
Copy link
Contributor Author

manikandanks2000 commented Jan 22, 2024

@bfreiberg project folder name modified as requested well.

@bfreiberg
Copy link
Contributor

To be clear, please change the folder name eventbridge_pipes_sqs_to_stepfunctions_python to just cdk. Because the name is unnecessary long and underscores in folder names are not allowed for patterns.

@manikandanks2000
Copy link
Contributor Author

I already have a variable aws_cdk as cdk in the python code, to avoid conflict have modified the folder name as "src" and stack file name as "cdkstack.py" . let me know if this is good or correcting it as cdk is your recommendation.

…thon/example-pattern.json


accepted the suggested changes

Co-authored-by: Ben <[email protected]>
@manikandanks2000
Copy link
Contributor Author

thanks for the guidance. hope it goes thru and will keep note of the changes recommended for my future contributions.

@bfreiberg
Copy link
Contributor

Looks good, thank you for your contribution. A Developer Advocate will merge the PR soon.

@julianwood julianwood merged commit 890887b into aws-samples:main Feb 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants