Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: errors constructing RSMSectionedPolynomialSensorModel from TREs #24

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

edparris
Copy link
Contributor

These changes fix errors in how RSMSectionedPolynomialSensorModels are constructed from TREs.

  • The floating point coefficients of the low order polynomial were incorrectly being transformed to int which caused ValueErrors.
  • The first section row/column numbers start at 1 not 0 so the code constructing the array of section sensor models needed to be updated to match.
  • We will release these fixes as an immediate PATCH release so the library version number has been incremented to 1.1.2.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants