Update container credentials method to use a different mount path #196
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Update container credentials method to use a different mount path than the STS AssumeRoleWithWebIdentity method. Prior this change, both methods will use the same mount path for the service account token. However, this approach may cause confusions during migration from the AssumeRoleWithWebIdentity method to the Container credentials method.
Suppose user has the following AWS config file, which would signal SDK to use the AssumeRoleWithWebIdentity method.
When the container credentials method is enabled for the service account, the audience of the token in
/var/run/secrets/eks.amazonaws.com/serviceaccount/token
will be set topods.eks.amazonaws.com
rather thansts.amazonaws.com
, and thus STS will return InvalidIdentityToken.A separate mount path is helpful because
Testing:
Mutated pod spec before this change
Mutated pod spec after this change
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.