Repo controlled build go version #206
Conversation
hack/third_party/gimme/README.md
Outdated
| @@ -0,0 +1,6 @@ | |||
| # gimme | |||
There was a problem hiding this comment.
Can you add why do we need to include gimme to the repo?
I am not familiar with this, if you can some pointers it will be helpful.
There was a problem hiding this comment.
Responded with details in another thread: #206 (comment)
hack/third_party/gimme/gimme
Outdated
There was a problem hiding this comment.
This is a shell script: https://github.com/travis-ci/gimme
Responded with details in another thread: #206 (comment)
| fi | ||
|
|
||
| # force go modules | ||
| export GO111MODULE=on |
There was a problem hiding this comment.
Isn't Go modules enabled by default?
There was a problem hiding this comment.
This is to make sure we force it on, in case it is disabled, and this setup-go.sh was taken from kubernetes-sigs/kind, which was later adopted in kubernetes repository as part of the work to keep Kubernetes on supported Go versions.
The gimme script has the ability to install temporarily in local environment with the exact specified Go version without interruption local Go installation. With this ability installed in a repo, when we are running any unit tests or integration tests, we can make sure we are running with the exact specified Go version from .go-version file.
See kubernetes adoption on gimme in: kubernetes/kubernetes#115377
See the initial adoption of gimme in kind in: https://github.com/kubernetes-sigs/kind/blob/main/hack/build/setup-go.sh
hack/setup-go.sh
Outdated
| # go version go1.14.5 darwin/amd64 | ||
| if ! ([ -n "${FORCE_HOST_GO:-}" ] || \ | ||
| (command -v go >/dev/null && [ "$(go version | cut -d' ' -f3)" = "go${GO_VERSION}" ])); then | ||
| # eval because the output of this is shell to set PATH etc. | ||
| eval "$(hack/third_party/gimme/gimme "${GO_VERSION}")" | ||
| fi |
There was a problem hiding this comment.
Is this to update Go version when building locally? If yes, I would keep the build option same docker build because we don't know how Go is being setup locally.
There was a problem hiding this comment.
Hi @prateekgogia We do keep the same option for docker build by:
.image-linux-%:
docker buildx build --output=type=docker --platform linux/$* \
--build-arg golang_image=$(shell hack/setup-go.sh) --no-cache \
--tag $(IMAGE):$(GIT_COMMIT)-linux_$* .
Here we explicitly call setup-go.sh with build-arg:
--build-arg golang_image=$(shell hack/setup-go.sh) --no-cache \
In this way, we are able to use exactly the Go image as base image with exactly the same version specified in .go-version file
This linked code change is in:
https://github.com/aws/amazon-eks-pod-identity-webhook/pull/206/files#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52R38
There was a problem hiding this comment.
Basically, this PR will make sure, when we are in:
build binaries
do unit tests
build images
github workflow CIs
We are using the exact specified Go version from .go-version in this repo, we call this repo controlled Go version setup.
Dockerfile
Outdated
| @@ -1,7 +1,9 @@ | |||
| FROM --platform=$BUILDPLATFORM golang:1.21 AS builder | |||
| ARG golang_image=golang:1.21 | |||
There was a problem hiding this comment.
Can we use this image here public.ecr.aws/eks-distro-build-tooling/golang?
Makefile
Outdated
|
|
||
| # Generic make | ||
| REGISTRY_ID?=602401143452 | ||
| REPO?=gcr.io/must-override |
There was a problem hiding this comment.
IIRC, we don't store images in gcr anymore.
|
|
||
| # Generic make | ||
| REGISTRY_ID?=602401143452 | ||
| REGISTRY?=public.ecr.aws |
There was a problem hiding this comment.
Do we already push this image to this repo?
There was a problem hiding this comment.
this is just a placeholder for override, for local docker build, it doesn’t matter
When an external user wants to build his own image and push it, he can do:
IMAGE=xxx make image
then do a docker push
Issue #, if available:
Description of changes:
Follow kubernetes/enhancements#3744 to make amazon-eks-pod-identity-webhook to stay on supported Go versions.
This PR follows kubernetes/kubernetes#114660 and kubernetes/kubernetes#115377 for repo-controlled go version to use in CI.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.