chore: add workflow to check if change file is included in a PR #887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philasmar
added
the
Release Not Needed
96malhar
reviewed
Dec 4, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #887 +/- ##
===========================================
+ Coverage 38.75% 62.81% +24.06%
===========================================
Files 282 282
Lines 10922 10922
Branches 1517 1517
===========================================
+ Hits 4233 6861 +2628
+ Misses 6382 3523 -2859
- Partials 307 538 +231 ☔ View full report in Codecov by Sentry. |
philasmar
force-pushed
the
asmarp/pr-check-for-change-files
branch
from
a70a0d2 to
5be68d8
Compare
96malhar
approved these changes
Dec 4, 2024
|
how will this work with release prs? #884 these dont have "release not needed" on them, yet change files are not required |
normj
approved these changes
Dec 4, 2024
philasmar
force-pushed
the
asmarp/pr-check-for-change-files
branch
from
bcebbcf to
458212b
Compare
Good catch @gcbeattyAWS! I updated the condition to skip PRs with the label 'Release PR' |
gcbeattyAWS
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
The PR updates the CONTRIBUTION.md file and adds a new Workflow that checks if a PR contains a
changefile. If a change file is not required, PRs should add the labelRelease Not Needed.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.