Update Node makefile create targets to use mock asl definition for testing #495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eginter
requested review from
hawflau and
jysheng123
and removed request for
a team
github-actions
bot
added
pr/external
stage/needs-triage
hawflau
approved these changes
Apr 1, 2024
hnnasit
approved these changes
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Related to #346
Description of changes:
Changes made in #346 created the mocked.test.asl.json file appropriately, but did not use it for the
aws stepfunctions create-state-machine --definitionargument. This PR updates the node v16/18/20 step-func makefiles to do so.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.