deploy_frontend.sh grep command fails on mac

[Srokit]

Description

sam init command creates a 'deploy_frontend.sh' script which will fail for MacOS's default grep command. This is a commonly used OS and grep version for developers. The mac grep command does not support the -P flag, but the generated script calls

invalidation_id=$(echo "$invalidation_output" | grep -oP '(?<="Id": ")[^"]+')

on line 41

that grep -oP part fails because the P option is not recognized.

I am sure there is another regex tool that we can use to extract that id string out of the invalidation_output (I have not come up with a solution myself yet).

The script will end up not waiting for the cloudfront invalidation-completed signal and will just end early. Not super breaking, but not ideal.

The solution I put in myself is not elegant and simply allows the error to happen and then calls ggrep instead which can be installed by homebrew on mac and has the -P option.

Steps to reproduce

On MacOS

Run

$ sam init

Select Option 1, then 13, then N, then N, then enter a name

Then

$ ./deploy_frontend.sh

See output

Observed result

usage: grep [-abcdDEFGHhIiJLlMmnOopqRSsUVvwXxZz] [-A num] [-B num] [-C[num]]
[-e pattern] [-f file] [--binary-files=value] [--color=when]
[--context[=num]] [--directories=action] [--label] [--line-buffered]
[--null] [pattern] [file ...]

usage: aws [options] [ ...] [parameters]
To see help text, you can run:

aws help
aws help
aws help

aws: error: argument --id: expected one argument

The invalidation is now complete - please visit your cloudfront URL to test

Expected result

Expected no errors

Additional environment details

1. OS: Mac OS Monterey 12.6.2 (21G320) (M1 Silicon)
2. If using the SAM CLI, sam --version: SAM CLI, version 1.97.0
3. AWS region: us-west-1

[xazhao]

Transfer the issue to sam cli.

[mrichman]

If you install jq you can do this: invalidation_id=$(echo $invalidation_output | jq -r '.Invalidation.Id')

[Srokit]

If you install jq you can do this: invalidation_id=$(echo $invalidation_output | jq -r '.Invalidation.Id')

You should add a PR for this and reference this issue :D

[Srokit]

Actually I'll make a PR. shouldn't be too tricky.

[Srokit]

@mrichman The jq command is not out of the box with Mac. Just tried it. I think we should have an out of the box solution.

[justinmk3]

Proposed fix: aws/aws-sam-cli-app-templates#458

[github-actions]

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.