Replace failing grep with builtin query #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cibinmathew
requested review from
moelasmar and
jysheng123
and removed request for
a team
github-actions
bot
added
pr/external
stage/needs-triage
Fixes: aws/aws-sam-cli#5940 Script was failing for MacOS's default grep command
hnnasit
approved these changes
Oct 25, 2023
There was a problem hiding this comment.
Hi @cibinmathew, thanks for your contribution. The changes in general look good to me but seems like some python3.10 tests unrelated to the changes are failing. We will look into fixing those.
moelasmar
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: aws/aws-sam-cli#5940 Script was failing for MacOS's default grep command
Description of changes:
Replace
grepwith aws cli's builtinqueryas-Pregex in grep is not supported by MacOSBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.