Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sign handler which adds Authorization header #99

Closed
wants to merge 1 commit into from

Conversation

cbroglie
Copy link

This fixes #94

@lsegal
Copy link
Contributor

lsegal commented Mar 14, 2015

Thanks for the PR @cbroglie! After some investigation we pulled back on the strategy of generating presigned URL signatures, since this causes issues with other protocols as well. req.Presign() still works, but header signing is now the default mode and both strategies are supported in the signer. It would possibly be worth refactoring some of this out into separate implementations, but the current implementation obsoletes this change, so I will close. I'll take a look at this code if we ever loop around to do a refactor.

@lsegal lsegal closed this Mar 14, 2015
@cbroglie
Copy link
Author

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants