Relocate ActionMailer and deprecate its railtie method #159
Conversation
|
@admtnnr This is where I did the refactoring work - I ended up removing automatic registration. I think I'll keep that bit regardless, but it sounds like you want this in a separate gem, too. |
mullermp
changed the title
Gemfile
Outdated
| @@ -4,6 +4,8 @@ source 'https://rubygems.org' | |||
|
|
|||
| gemspec | |||
|
|
|||
| gem 'aws-actionmailer-ses', git: 'https://github.com/aws/aws-actionmailer-ses-ruby', branch: 'init' | |||
There was a problem hiding this comment.
why branch init here? Is this just temporary for testing until we merge the other PR?
There was a problem hiding this comment.
Yeah this was temporary. I'm going to again keep this here until we release aws-sdk-rails and all four gems have been published.
| @@ -202,14 +202,24 @@ use the provided Rake task: | |||
| rake dynamo_db:session_store:clean | |||
| ``` | |||
|
|
|||
| ## Amazon Simple Email Service (SES) as an ActionMailer Delivery Method | |||
| ## ActionMailer delivery with Amazon Simple Email Service | |||
There was a problem hiding this comment.
Should we go ahead and just link to the README in the other repo here?
There was a problem hiding this comment.
That's the plan but I wasn't sure whether to do that now or later (trying to avoid confusion) because the other readme says to install the gem which doesn't exist. For now I just duplicated the info and will delete this in one sweep.
This change moves the ActionMailer mailers to aws/aws-actionmailer-ses-ruby#1 and changes their namespace and class names. The railtie method that has caused issues is also removed. With this approach, customers are advised to configure their own delivery method using whatever class and name they want to, as well as providing client options. This change also updates the testing guide for this feature.