Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare aws-sdk-rails 5 #166

Merged
merged 4 commits into from
Nov 21, 2024
Merged

Prepare aws-sdk-rails 5 #166

merged 4 commits into from
Nov 21, 2024

Conversation

mullermp
Copy link
Contributor

Major version bumps aws-sdk-rails plus some additional changes:

  • Drops dependencies on modular gems.
  • Removes Aws::Rails.action_mailer_delivery_method.
  • Removes old action mailbox require path.
  • Removes old symlinked namespaces.
  • ActiveSupport Notification plugin added by default.
  • Moved initializers into their own initialization method and set appropriate ordering.
  • Do not execute ActiveJob with cron unless path is root.

alextwoods
alextwoods reviewed Nov 20, 2024
View reviewed changes
aws-sdk-rails.gemspec Show resolved Hide resolved
lib/aws/rails/middleware/elastic_beanstalk_sqsd.rb Outdated Show resolved Hide resolved
lib/aws/rails/middleware/elastic_beanstalk_sqsd.rb Show resolved Hide resolved
lib/aws/rails/middleware/elastic_beanstalk_sqsd.rb Show resolved Hide resolved
lib/aws/rails/railtie.rb Show resolved Hide resolved
@mullermp mullermp merged commit 76598dd into main Nov 21, 2024
15 checks passed
@mullermp mullermp deleted the 5.0 branch November 21, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alextwoods alextwoods alextwoods approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mullermp @alextwoods