Support async job processing in EBS SQSD middleware #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mullermp
approved these changes
Dec 4, 2024
mullermp
approved these changes
Dec 4, 2024
sample-app/Gemfile
Outdated
| @@ -2,7 +2,7 @@ source "https://rubygems.org" | |||
|
|
|||
| # Our gems | |||
| # bundle config set local.aws-sdk-rails ../ | |||
| gem 'aws-sdk-rails', git: 'https://github.com/aws/aws-sdk-rails', branch: 'main' | |||
| gem 'aws-sdk-rails', path: "../" | |||
There was a problem hiding this comment.
Don't forget to change this back - you can set the branch and use bundler config local.
sample-app/app/jobs/test_job.rb
Outdated
| @@ -4,5 +4,8 @@ class TestJob < ApplicationJob | |||
|
|
|||
| def perform(*args) | |||
| puts "Job performed with args: #{args}" | |||
| if args[0].is_a?(Hash) && args[0][:error] | |||
There was a problem hiding this comment.
Probably not necessary, or if you want to keep, maybe a TestErrorJob or also place this code in async.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#167
Description of changes:
Adds new ENV configuration to opt-in to async job processing in EBS SQSD middleware.
Async job processing is done using a thread pool executor. When there is capacity, the job is queued and a 200 OK is returned immediately. When there is no capacity, the middleware returns a 429 (too many requests) which will cause the SQSD to NOT delete the message, leaving it in the queue for future processing.
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license.