Skip to content

Commit

Permalink
Handle cases where GitHub release does not exist for tag (#3116)
Browse files Browse the repository at this point in the history
  • Loading branch information
abhay-krishna authored Apr 26, 2024
1 parent c99ab68 commit 4c39241
Showing 1 changed file with 9 additions and 2 deletions.
11 changes: 9 additions & 2 deletions tools/version-tracker/pkg/github/github.go
Original file line number Diff line number Diff line change
Expand Up @@ -149,10 +149,17 @@ func GetLatestRevision(client *github.Client, org, repo, currentRevision string,
}
}
releaseForTag, _, err := client.Repositories.GetReleaseByTag(context.Background(), org, repo, tagName)
preRelease := false
if err != nil {
return "", false, fmt.Errorf("calling GetReleaseByTag API for tag %s in [%s/%s] repository: %v", tagName, org, repo, err)
if strings.Contains(err.Error(), "404 Not Found") {
preRelease = false
} else {
return "", false, fmt.Errorf("calling GetReleaseByTag API for tag %s in [%s/%s] repository: %v", tagName, org, repo, err)
}
} else {
preRelease = *releaseForTag.Prerelease
}
if *releaseForTag.Prerelease {
if preRelease {
continue
}

Expand Down

0 comments on commit 4c39241

Please sign in to comment.