disable cgroupns in kind/capd #2405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
eks-distro-bot
added
the
size/M
jaxesn
force-pushed
the
jgw/disable-cgroupns-private-kind
branch
from
9136071
to
6acd857
Compare
jaxesn
force-pushed
the
jgw/disable-cgroupns-private-kind
branch
from
6acd857
to
dce8b94
Compare
|
Merging to get a build to test, will revert if needed. |
jaxesn
added a commit
to jaxesn/eks-anywhere-build-tooling
that referenced
this pull request
Aug 21, 2023
eks-distro-bot
pushed a commit
that referenced
this pull request
Aug 21, 2023
* Bump cluster-api, cert-manager and kind to latest versions (#2402) * Latest eks-d versions (#2401) * disable cgroupns in kind/capd (#2405) * revert runc and containerd in kind image (#2406) * revert runc and containerd in kind image * Update CHECKSUMS * do not lock containerd version (#2412) * do not lock containerd version * Update CHECKSUMS --------- Co-authored-by: Abhay Krishna <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Not totally sure why but using cgroupns=private on AL2 nodes, this did not seem to be an issue on Ubuntu 20.04 nodes which is also cgroup v1, seems to cause issues creating the containers instead the kind node image.
Kind 0.20 does call out that using cgroupns=default with cgroupv1 is deprecated and will eventually be removed. The code to handle this case has been in the entrypoint.sh script for quite some time and we can continue to maintain this in our patches if necessary.
Newer distro, Ubuntu 22.04 and AL23, use cgroup v2 which are not affected by this change since docker already defaults to cgroupns=private for cgroup v2 hosts.
I confirmed this issue exist on an AL2 using the upstream kind binary and upstream kind node image as well. Using this patched version of kind, I was able to create a cluster with both the upstream image and the eks-a al23 based node image.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.