Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump capi to v1.4.6 and cert-manager to v1.12.3 #2450

Merged
merged 1 commit into from
Aug 30, 2023

Conversation

g-gaston
Copy link
Member

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@abhay-krishna
Copy link
Member

/test all

@abhay-krishna
Copy link
Member

/lgtm

@abhay-krishna
Copy link
Member

/ok-to-test

@eks-distro-bot eks-distro-bot added ok-to-test size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 29, 2023
@jaxesn
Copy link
Member

jaxesn commented Aug 29, 2023

want to backport this?

@g-gaston
Copy link
Member Author

want to backport this?

@jaxesn I wasn't planning on doing it but we could.

However, I don't want to do the rebase again, it was a pain (release-0.17 would require a new rebase of the patches since they are different that in main). So if we feel confident with the current patches in main (we would need to check the e2e signal for the last few days), then I would suggest just copying all the patches from main to avoid the extra work.

I don't see anything in the changelog that we need in v0.17.1.

@abhay-krishna
Copy link
Member

/lgtm
/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhay-krishna

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot merged commit 7ad60a6 into aws:main Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ok-to-test size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants