Update go install for minimal images to use the existing go version #1450
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
github-actions
bot
added
the
minimal-image
rcrozean
force-pushed
the
goInstallGo
branch
2 times, most recently
from
f93e008
to
54e8a39
Compare
…tching eksgo installs
| for arch in ${archs/,/ }; do | ||
| local filename="$outputDir/${arch}/go$version.${arch/\//-}.tar.gz" | ||
| if [ ! -f $filename ]; then | ||
| curl -sSLf --retry 5 "https://go.dev/dl/go$version.${arch/\//-}.tar.gz" -o $filename --create-dirs |
There was a problem hiding this comment.
it would probably be best to check the checksums here. if you want to follow the pattern we use elsewhere, we could check those in or download them from go.dev, like we did the rpm shas above. again but not strictly required but would be at least slightly better
There was a problem hiding this comment.
Made the additions for checking the sha and here is the local output.
+ curl -sSLf --retry 5 https://go.dev/dl/go1.22.4.linux-amd64.tar.gz -o /tmp/test/linux/amd64/go1.22.4.linux-amd64.tar.gz --create-dirs
++ curl -sSLf --retry 5 'https://go.dev/dl/?mode=json'
++ jq -r --arg tar go1.22.4.linux-amd64.tar.gz '.[].files[] | if .filename == $tar then .sha256 else "" end'
++ xargs
+ sha256sum=ba79d4526102575196273416239cca418a651e049c2b099f3159db85e7bade7d
++ sha256sum /tmp/test/linux/amd64/go1.22.4.linux-amd64.tar.gz
++ cut '-d ' -f1
+ [[ ba79d4526102575196273416239cca418a651e049c2b099f3159db85e7bade7d != \b\a\7\9\d\4\5\2\6\1\0\2\5\7\5\1\9\6\2\7\3\4\1\6\2\3\9\c\c\a\4\1\8\a\6\5\1\e\0\4\9\c\2\b\0\9\9\f\3\1\5\9\d\b\8\5\e\7\b\a\d\e\7\d ]]
|
@rcrozean: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Issue #, if available:
Description of changes:
Since EKS Distro is deprecating EKS Go and don't want to continue building the RPMs for the versions upstream is supporting, we can use the existing golang installed on the builder base to install the newest versions. In this pr I am preserving the old eksgo install function but renaming them to
::eksgo::*. The new function callsgo installandgo downloadto install and unpack the newest version of golang produced by upstream following managing multiple golang installs. This followed with a prowjob to auto bump theversions.yamlandnullthe golang minimal images (#1449) is the proposed new method for installing golang on the builder baseBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.