-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add infrastructure for generating the golang-debian image using upstream binaries #1474
Conversation
…bian image builds
…hen pulling upstream binaries
PR for updating relevant Prowjobs aws/eks-distro-prow-jobs#621 |
/retest |
@rcrozean: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/retest |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rcrozean The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Issue #, if available:
Description of changes:
These changes were tested using the new
make local-images-upstream-bins
which is identical to the final call exceptPUSH_IMAGES=false
. Both of these based of the make targets for building the current debian images with new variables and scripts used pulling upstream binaries instead of the EKS Go s3 images previously generated.Output from the
make local-images-upstream-bins
command calling the newget_upstream_golang.sh
. This script checks the builder-base files for referencing which version of golang the debian images should use. From here the Makefile and Dockerfile create the relevant image using the tags. Using the existing postsubmits we can trigger off a merge of theeks-distro-base/golang_versions.yaml
(this file should be used as it will be updated with the same automation that update thebuilder-base/versions.yaml
but only will be updated when golang versions are updated), instead of thedocker/debianBase/RELEASE
file.Relevant output from buildkit and docker:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.