-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 131 | NodeConfigCompare : In the Prerequisites mention network URLs to be allow listed #132
Open
akshayar
wants to merge
4
commits into
aws:main
Choose a base branch
from
akshayar:issue-131
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
cf3febc
Region config in redshift-test-drive/main/config/extract.yaml not us…
akshayar c12d4a9
NodeConfigCompare : In the Prerequisites mention network URLs to be …
akshayar 230a70e
Merge pull request #1 from aws/main
akshayar fee95e8
Merge branch 'main' of https://github.com/akshayar/redshift-test-driv…
akshayar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @akshayar, thanks for raising the issue and creating a PR. Appreciate your effort. But before I approve I want to understand few things just for more clarity, I understand the URLs
public.ecr.aws
for ECR image ,github.com/aws/redshift-test-drive.git
for Cloning the repo,pypi.org
for python packages. I want to understand the URLsfiles.pythonhosted.org
,d2glxqk2uabbnd.cloudfront.net
andcdn.amazonlinux.com
and where/what they are used for.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me pull the logs to find out the exact line where it failed. This will help us find that out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That will be helpful. Thanks