Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing a bug in logging an extract run #139

Merged
merged 1 commit into from
Feb 5, 2024
Merged

Conversation

DevanathanSabapathy1
Copy link
Contributor

Issue #, if available:
When Cluster endpoint was not given, it breaks extract because of a recent code addition for logging.
Description of changes:
Added an if statement for now, to unblock the customer.
But we should have an elaborate discussion on if we need to have this logging done for extract because when the customer does not give the cluster endpoint we wont log extract as being used. THis wont give a full picture of how many times extract was used. Also logging Replay is more useful in my opinion than extract as customers cant do much with just the extract.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@karle-nishi
Copy link
Contributor

Hey Dev,
Did you test this? Because locally I had tried doing the same but I get Unable to locate credentials error.

@DevanathanSabapathy1
Copy link
Contributor Author

YEs tested it with and without the cluster endpoint and it worked.
Your error seems to be that aws credentials are not properly set ?

@DevanathanSabapathy1 DevanathanSabapathy1 merged commit f99a67a into main Feb 5, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants