Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create stats_lambda.yml #6570

Closed
wants to merge 51 commits into from
Closed

Create stats_lambda.yml #6570

wants to merge 51 commits into from

Conversation

brmur
Copy link
Contributor

@brmur brmur commented Jun 20, 2024

GH action to trigger Run the Numbers Lambda function to generate statistics for repo.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Action to trigger run the Numbers lambda
@brmur brmur requested a review from beqqrry-aws June 20, 2024 15:38
@github-actions github-actions bot added the GitHub settings This affects GitHub settings label Jun 20, 2024
FunctionName: runTheNumbers
Payload: ${{env.JSON_PAYLOAD}}
InvocationType: RequestResponse
LogType: None
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The whole file has inconsistent spacing. This is getting missed by the linter (separate issue) but each indent should be 2 spaces.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linter has been updated and you can see the spacing line errors in the action details. The truthy one I covered on the comment for line 8.

# https://github.com/marketplace/actions/invoke-aws-lambda

name: Invoke runTheNumbers lambda functions
on:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this line should be:
on: # yamllint disable-line rule:truthy
(this is new since you created this PR)

@brmur
Copy link
Contributor Author

brmur commented Jun 21, 2024

Closing to test whether subsequent changes to linter have broken ability of this action to call AWS credentials.

@brmur brmur closed this Jun 21, 2024
@brmur brmur mentioned this pull request Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GitHub settings This affects GitHub settings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants