-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tools - Writeme: Updates to logging #6592
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ford-at-aws
added
Task
A general update to the code base for language clarification, missing actions, tests, etc.
Tools
This issue relates to a custom tooling to streamline development tasks
labels
Jul 2, 2024
DavidSouther
requested changes
Jul 2, 2024
ford-at-aws
force-pushed
the
writeme-fixes
branch
2 times, most recently
from
July 2, 2024 20:40
45c4993
to
8761248
Compare
Rebased and fixed items. Nits were from not running formatter and added unused var prefix. |
DavidSouther
requested changes
Jul 2, 2024
DavidSouther
approved these changes
Jul 2, 2024
github-actions
bot
added
the
Python
This issue relates to the AWS SDK for Python (boto3)
label
Jul 2, 2024
ford-at-aws
force-pushed
the
writeme-fixes
branch
from
July 3, 2024 15:04
6f5ae87
to
8e00ace
Compare
meyertst-aws
added
On Call Review complete
On call review complete
and removed
On Call Review needed
This work needs an on-call review
labels
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
On Call Review complete
On call review complete
Python
This issue relates to the AWS SDK for Python (boto3)
Task
A general update to the code base for language clarification, missing actions, tests, etc.
Tools
This issue relates to a custom tooling to streamline development tasks
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some better logging for users to understand what the script is doing.