Skip to content

Commit

Permalink
Fix GCC and Windows CI Tests (#1105)
Browse files Browse the repository at this point in the history
* Update ci.yml compiler env var

* Add refreshenv to windows build

* Add import module for refreshenv call

* Testing

* Revert windows CI changes

* Update ci.yml

* Trying different PKG_CONFIG_EXECUTABLE path

* Add msvc_ to path

* More build testing

* more

* more

* more

* more

* more

* more

* more

* more

* more

* more

* more

* more

* more

* more

* more

* more

* works, testing which line(s) is needed

* more

* more

* Cleanup ci

* cleanup cmake

* Update README.md

* Add check for C vs D drive

* Revert ReadMe changes
  • Loading branch information
stefankiesz committed Nov 29, 2023
1 parent 9ad8a59 commit efc9126
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 5 deletions.
8 changes: 4 additions & 4 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,8 @@ jobs:
id-token: write
contents: read
env:
CC: gcc
CXX: g++
CC: /usr/local/bin/gcc-13
CXX: /usr/local/bin/g++-13
AWS_KVS_LOG_LEVEL: 2
steps:
- name: Clone repository
Expand Down Expand Up @@ -205,7 +205,7 @@ jobs:
timeout --signal=SIGABRT 60m ./tst/producerTest
# memory-sanitizer:
# runs-on: ubuntu-20.04
# runs-on: ubuntu-20.04
# permissions:
# id-token: write
# contents: read
Expand Down Expand Up @@ -304,7 +304,7 @@ jobs:
run: |
choco install nasm strawberryperl
choco install gstreamer --version=1.16.2
choco install gstreamer-devel --version=1.16.2
choco install gstreamer-devel --version=1.16.2
- name: Build repository
run: |
$env:Path += ';C:\Strawberry\perl\site\bin;C:\Strawberry\perl\bin;C:\Strawberry\c\bin;C:\Program Files\NASM;D:\a\amazon-kinesis-video-streams-producer-sdk-cpp\amazon-kinesis-video-streams-producer-sdk-cpp\open-source\local\lib;D:\a\amazon-kinesis-video-streams-producer-sdk-cpp\amazon-kinesis-video-streams-producer-sdk-cpp\open-source\local\bin'
Expand Down
6 changes: 5 additions & 1 deletion CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,11 @@ else()
endif()

if (WIN32)
set(PKG_CONFIG_EXECUTABLE "C:\\gstreamer\\1.0\\x86_64\\bin\\pkg-config.exe")
if(EXISTS "C:\\gstreamer\\1.0\\x86_64\\bin\\pkg-config.exe")
set(PKG_CONFIG_EXECUTABLE "C:\\gstreamer\\1.0\\x86_64\\bin\\pkg-config.exe")
else()
set(PKG_CONFIG_EXECUTABLE "D:\\gstreamer\\1.0\\x86_64\\bin\\pkg-config.exe")
endif()
endif()

############# Enable Sanitizers ############
Expand Down

0 comments on commit efc9126

Please sign in to comment.