addressing comments + adding win debug ci

awslabs · Jun 20, 2024 · 9b50d48 · 9b50d48
1 parent 6f98669
commit 9b50d48
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -129,6 +129,15 @@ jobs:
         python -c "from urllib.request import urlretrieve; urlretrieve('${{ env.BUILDER_HOST }}/${{ env.BUILDER_SOURCE }}/${{ env.BUILDER_VERSION }}/builder.pyz?run=${{ env.RUN }}', 'builder.pyz')"
         python builder.pyz build -p ${{ env.PACKAGE_NAME }}
 
+  windows-debug:
+    runs-on: windows-2022 # latest
+    steps:
+    - name: Build ${{ env.PACKAGE_NAME }} + consumers
+      run: |
+        python -c "from urllib.request import urlretrieve; urlretrieve('${{ env.BUILDER_HOST }}/${{ env.BUILDER_SOURCE }}/${{ env.BUILDER_VERSION }}/builder.pyz?run=${{ env.RUN }}', 'builder.pyz')"
+        python builder.pyz build -p ${{ env.PACKAGE_NAME }} --config Debug
+
+
   windows-vc14:
     runs-on: windows-2019 # windows-2019 is last env with Visual Studio 2015 (v14.0)
     strategy:

diff --git a/source/windows/bcrypt_aes.c b/source/windows/bcrypt_aes.c
@@ -551,7 +551,7 @@ static struct aws_byte_cursor s_gcm_get_working_slice(
     struct aws_byte_cursor data,
     struct aws_byte_buf *scratch) {
     AWS_PRECONDITION(cipher_impl);
-    AWS_PRECONDITION(working_buf);
+    AWS_PRECONDITION(scratch);
 
     AWS_ZERO_STRUCT(*scratch);