appropriately handling option parsing by adding '--'s and removing '--'s #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oanise93
force-pushed
the
modify_resolve_options
branch
from
53256d1 to
182ef6e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
According to the documentation, the function
getResolvedOptionsexpects theoptionsparameter to contain arguments without'--'prepended to them. However, in some cases when the function is checking for reserved arguments, it assumes that the options are prepended with--. This allows arguments that should be reserved to "pass" these checks but end up generating aargparse.ArgumentError: argument --<option>: conflicting option string: --<option>error because the same option is trying to be added twice. This pull request tries to solve this issue and have the correct errors raised when this occurs.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.