feat: Automatically detect Go version in the pipeline #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tzneal
reviewed
Nov 28, 2023
| with: | ||
| go-version: 'stable' | ||
| go-version-file: 'go.mod' |
There was a problem hiding this comment.
This means we'll need to update go.mod at release to ensure we don't release using Go with a CVE though, right?
There was a problem hiding this comment.
We have check-latest: true so it will only be used to bump minor release, which we'll probably do via go.mod, I assume 🤔
There was a problem hiding this comment.
I think I'd prefer to keep using 'stable' as it automatically uses the latest stable go whenever a release is made. I don't trust myself to update go.mod as frequently 😆
There was a problem hiding this comment.
Sure, I just think it's a nice mechanism testing what the codebase is set to run with, but there could be value in having it future tested too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: n/a
Description of changes:
Pipelines will automatically use Go version based on
go.modBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.