Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move from pytorch_lightning to lightning #3013

Merged
merged 5 commits into from
Oct 16, 2023

Conversation

shchur
Copy link
Contributor

@shchur shchur commented Oct 13, 2023

Description of changes:

  • Fix the breaking change to load_from_checkpoint introduced by pytorch_lightning==2.1.0.
  • Install the new package name lightning instead of pytorch_lightning
  • Use the new import style lightning.pytorch instead of pytorch_lightning

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Please tag this pr with at least one of these labels to make our release process faster: BREAKING, new feature, bug fix, other change, dev setup

@shchur shchur requested a review from lostella October 13, 2023 14:23
@@ -2,7 +2,7 @@

```{toctree}
:maxdepth: 1
howto_pytorch_lightning
howto_lightning.pytorch
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This slipped in I guess?

Copy link
Contributor

@lostella lostella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One change to revert in the docs I believe, otherwise looks good, thank you @shchur!

@lostella lostella added the pending v0.13.x backport This contains a fix to be backported to the v0.13.x branch label Oct 14, 2023
@lostella lostella added the pr:docs-build-notebook Build notebooks for pull-request. label Oct 16, 2023
@lostella lostella changed the title Move from pytorch_lightning to lightning Move from pytorch_lightning to lightning Oct 16, 2023
@lostella lostella merged commit ec2beb9 into awslabs:dev Oct 16, 2023
19 checks passed
@shchur shchur deleted the lightning-upgrade branch October 16, 2023 08:22
lostella pushed a commit to lostella/gluonts that referenced this pull request Oct 16, 2023
@lostella lostella mentioned this pull request Oct 16, 2023
lostella added a commit that referenced this pull request Oct 16, 2023
* [torch] Return a model even if callback has no best model path (#2952)

* Move from `pytorch_lightning` to `lightning` (#3013)

---------

Co-authored-by: Kashif Rasul <[email protected]>
Co-authored-by: Oleksandr Shchur <[email protected]>
@caseytomlin
Copy link

Hi, maybe I'm doing something else wrong, but this new import syntax seems to not work with pytorch_lightning<2.0.0, but the requirements allow otherwise. is it just me?

image

@shchur
Copy link
Contributor Author

shchur commented Oct 20, 2023

Thanks @caseytomlin, we have released v0.13.7 that uses the old import style and therefore is compatible with the correct version ranges.

We will update the version ranges in v0.14.0, where the the new import style will be introduced.

@lostella lostella removed the pending v0.13.x backport This contains a fix to be backported to the v0.13.x branch label Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:docs-build-notebook Build notebooks for pull-request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants