Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ECDSA subquery #16

Merged
merged 5 commits into from
Apr 18, 2024
Merged

feat: add ECDSA subquery #16

merged 5 commits into from
Apr 18, 2024

Conversation

rpalakkal
Copy link
Contributor

No description provided.

@rpalakkal rpalakkal requested a review from jonathanpwang April 17, 2024 18:35
builder: &mut RlcCircuitBuilder<Fr>,
subquery_caller: Arc<Mutex<SubqueryCaller<P, Fr>>>,
) -> HiLo<AssignedValue<Fr>> {
let raw_subquery = custom_parameters_ecdsa(1, 1, 1);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a single test case?

Copy link
Contributor

@jonathanpwang jonathanpwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK to merge after fixing CI (I added deploy key, now some ethers issue I believe)

@rpalakkal rpalakkal merged commit 1c2ba5c into develop Apr 18, 2024
1 check passed
@rpalakkal rpalakkal deleted the feat/ecdsa-only branch April 18, 2024 15:27
rpalakkal added a commit that referenced this pull request Apr 18, 2024
* feat: add ecdsa subquery

* fix: update axiom-components rep

* chore: add axiom-eth deploy key to workflow

* chore: fix cargo git

* fix: ethers version

---------

Co-authored-by: Jonathan Wang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants