Skip to content

Commit

Permalink
chore: rename function
Browse files Browse the repository at this point in the history
  • Loading branch information
jonathanpwang committed Oct 20, 2023
1 parent 5cccb0f commit ba904da
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions hashes/zkevm/src/keccak/component/circuit/shard.rs
Original file line number Diff line number Diff line change
Expand Up @@ -296,7 +296,7 @@ impl<F: Field> KeccakComponentShardCircuit<F> {
) -> Vec<LoadedKeccakF<F>> {
let rows_per_round = self.params.keccak_circuit_params.rows_per_round;
let base_circuit_builder = self.base_circuit_builder.borrow();
load_keccak_assigned_rows(
transmute_keccak_assigned_to_virtual(
&base_circuit_builder.core().copy_manager,
assigned_rows,
rows_per_round,
Expand Down Expand Up @@ -476,15 +476,16 @@ pub fn encode_inputs_from_keccak_fs<F: Field>(
initialized_hasher.hash_compact_chunk_inputs(ctx, gate, &compact_chunk_inputs)
}

/// Load needed witnesses into halo2-lib from keccak assigned rows. This function doesn't create any witnesses/constraints.
/// Converts the pertinent raw assigned cells from a keccak_f permutation into virtual `halo2-lib` cells so they can be used
/// by [halo2_base]. This function doesn't create any new witnesses/constraints.
///
/// This function is made public for external libraries to use for compatibility. It is the responsibility of the developer
/// to ensure that `rows_per_round` **must** match the configuration of the vanilla zkEVM Keccak circuit itself.
///
/// ## Assumptions
/// - `rows_per_round` **must** match the configuration of the vanilla zkEVM Keccak circuit itself.
/// - `assigned_rows` **must** start from the 0-th row of the keccak circuit. This is because the first `rows_per_round` rows are dummy rows.
pub fn load_keccak_assigned_rows<F: Field>(
pub fn transmute_keccak_assigned_to_virtual<F: Field>(
copy_manager: &SharedCopyConstraintManager<F>,
assigned_rows: Vec<KeccakAssignedRow<'_, F>>,
rows_per_round: usize,
Expand Down

0 comments on commit ba904da

Please sign in to comment.