Feat: zkvm target for the ruint library #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@arayikhalatyan -- can you make an |
jonathanpwang
requested changes
Dec 11, 2024
| #[must_use] | ||
| pub fn arithmetic_shr(mut self, rhs: usize) -> Self { | ||
| if BITS == 256 { | ||
| let rhs = if rhs >= 256 { 255 } else { rhs }; |
There was a problem hiding this comment.
I had to review arithmetic shifts for this. It is correct.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves INT-2605
Note their shift operations are a bit different from the RiscV ones so we had to have a special case handling
Probably can do some more optimizations with additional native extern functions. Like for
div/rem- can probably do using a phantom instruction with similar logic toHintDecompress