Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(reactmultiemail.tsx): trim emails with space after comma #165

Merged

Conversation

jhaltercmu2020
Copy link
Contributor

trim emails with space after comma. If you copy something like: [email protected], [email protected], [email protected] the space is

trim emails with space after comma. If you copy something like: [email protected],
[email protected], [email protected] the space is
@vercel
Copy link

vercel bot commented Oct 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-multi-email ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 26, 2023 5:26pm

@jhaltercmu2020
Copy link
Contributor Author

@thomasJang Can you take a look? The reason why we need to make this change is because if you copy something like this:

the spaces are causing issues and if we trim the space everything works as expected. Let me know if you have any questions.

@thomasJang
Copy link
Member

Yes!, I think this code don't make side effect.

@jhaltercmu2020
Copy link
Contributor Author

@thomasJang Thanks, would you be able to tag a few others with approval access to review?

@thomasJang thomasJang merged commit 055dec7 into axisj:master Oct 28, 2023
2 checks passed
@thomasJang
Copy link
Member

Thx. @jhaltercmu2020 1.0.18 is out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants