Skip to content

Commit

Permalink
pr feedback changes
Browse files Browse the repository at this point in the history
  • Loading branch information
winglian committed Nov 29, 2024
1 parent 4c25ee9 commit 59a947c
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions tests/e2e/patched/test_unsloth_qlora.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
os.environ["WANDB_DISABLED"] = "true"


# pylint: disable=duplicate-code
class TestUnslothQLoRA:
"""
Test class for Unsloth QLoRA Llama models
Expand All @@ -29,7 +30,6 @@ class TestUnslothQLoRA:
[True, False],
)
def test_unsloth_llama_qlora_fa2(self, temp_dir, sample_packing):
# pylint: disable=duplicate-code
cfg = DictDefault(
{
"base_model": "HuggingFaceTB/SmolLM2-135M",
Expand Down Expand Up @@ -80,8 +80,7 @@ def test_unsloth_llama_qlora_fa2(self, temp_dir, sample_packing):
df = df[(df.tag == "train/train_loss")] # pylint: disable=invalid-name
assert df.value.values[-1] < 2.0, "Loss is too high"

def test_unsloth_llama_qlora_unpacked_no_fa2(self, temp_dir):
# pylint: disable=duplicate-code
def test_unsloth_llama_qlora_unpacked(self, temp_dir):
cfg = DictDefault(
{
"base_model": "HuggingFaceTB/SmolLM2-135M",
Expand Down Expand Up @@ -136,7 +135,6 @@ def test_unsloth_llama_qlora_unpacked_no_fa2(self, temp_dir):
[True, False],
)
def test_unsloth_llama_qlora_unpacked_no_fa2_fp16(self, temp_dir, sdp_attention):
# pylint: disable=duplicate-code
cfg = DictDefault(
{
"base_model": "HuggingFaceTB/SmolLM2-135M",
Expand Down

0 comments on commit 59a947c

Please sign in to comment.