-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update @fadroma/schema to 1.1.0 #342
Conversation
Codecov Report
@@ Coverage Diff @@
## main #342 +/- ##
==========================================
+ Coverage 98.04% 98.25% +0.21%
==========================================
Files 41 42 +1
Lines 8861 9766 +905
==========================================
+ Hits 8688 9596 +908
+ Misses 173 170 -3 see 8 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more 📢 Have feedback on the report? Share it here. |
Hello @egasimus The following is all about suggestions, and fully open to discussions. We understand your awareness concerns, but we are looking to work in another way to value/reward contributors. We better prefer to grant |
Hi @antho31! Adding a reference to the inputs and generating tool in generated documentation is a normal thing that some doc generators do and some don't, e.g.
Though I do notice that neither Docusaurus nor mdBook elect to do it 🤷 Either way, this is a general contribution in accordance with established FOSS practices. It effectively costs you nothing to lend us this tiny bit of publiciity - but I'm willing to remove the links from axone-protocol/docs#276 if this will expedite the publication of the fixed docs. I'm happy to hear that this contribution also fits the criteria for Dagda (if I understand you correctly). We actually have something else in mind for the builders program - and yes, it includes adding a full OKP4 client to Fadroma :-) We planned to publish that by Aug 30, then hit a snag with a lot of the foundational libraries ( If all goes well, we plan to release a beta version of our graphical chain explorer with OKP4 support by Sep 30. Please email us at |
Alright, just sent you a mail :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 🙏 !
By changing version, the new documentation generated differ and linter doesn't accept if you don't commit this new documentation.
If you can please commit the new generated documentation so that it can be up to date on the docs repository 😇:
cargo make docs-generate
Done! 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx! 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏 Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 🙏!
This adds a footer to generated docs which contains:
I hope the latter two are acceptable. We're trying to raise awareness of our toolkit's existence, and would be happy to collaborate more closely with your team in the future.