Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update @fadroma/schema to 1.1.0 #342

Merged
merged 2 commits into from
Sep 8, 2023
Merged

Conversation

egasimus
Copy link
Contributor

This adds a footer to generated docs which contains:

I hope the latter two are acceptable. We're trying to raise awareness of our toolkit's existence, and would be happy to collaborate more closely with your team in the future.

@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Merging #342 (c80889d) into main (bd3470a) will increase coverage by 0.21%.
Report is 37 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #342      +/-   ##
==========================================
+ Coverage   98.04%   98.25%   +0.21%     
==========================================
  Files          41       42       +1     
  Lines        8861     9766     +905     
==========================================
+ Hits         8688     9596     +908     
+ Misses        173      170       -3     

see 8 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

📢 Have feedback on the report? Share it here.

@antho31
Copy link

antho31 commented Sep 1, 2023

Hello @egasimus

The following is all about suggestions, and fully open to discussions.

We understand your awareness concerns, but we are looking to work in another way to value/reward contributors.

We better prefer to grant fadroma's use as a Builder program's open contribution (the 4th challenge of "Invoke the power of Dagda" part, eligible up to 100 000 $KNOW).
And even for deeper collaboration, what about a similar package as well as there is with Secret, for OKP4? We saw OKP4 mentioned in the Medium article :)

@egasimus
Copy link
Contributor Author

egasimus commented Sep 5, 2023

Hi @antho31!

Adding a reference to the inputs and generating tool in generated documentation is a normal thing that some doc generators do and some don't, e.g.

TypeDoc:

Screenshot from 2023-09-01 16-48-09

Sphinx/Read the Docs:

Screenshot from 2023-09-01 16-47-20

Though I do notice that neither Docusaurus nor mdBook elect to do it 🤷

Either way, this is a general contribution in accordance with established FOSS practices. It effectively costs you nothing to lend us this tiny bit of publiciity - but I'm willing to remove the links from axone-protocol/docs#276 if this will expedite the publication of the fixed docs.

I'm happy to hear that this contribution also fits the criteria for Dagda (if I understand you correctly). We actually have something else in mind for the builders program - and yes, it includes adding a full OKP4 client to Fadroma :-)

We planned to publish that by Aug 30, then hit a snag with a lot of the foundational libraries (@cosmjs/stargate and protobuf.js among others) not being natively ESM-compatible. So I'm currently working on a comprehensive solution for all that (which I hope will benefit not only OKP4, but CosmWasm and the JS ecosystem in general).

If all goes well, we plan to release a beta version of our graphical chain explorer with OKP4 support by Sep 30. Please email us at hello at fadroma dot tech and let's have a conversation about how to best move this forward - imho GitHub Issues aren't the best medium for strategic discussion.

@antho31
Copy link

antho31 commented Sep 7, 2023

Alright, just sent you a mail :)

Copy link
Contributor

@bdeneux bdeneux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙏 !
By changing version, the new documentation generated differ and linter doesn't accept if you don't commit this new documentation.
If you can please commit the new generated documentation so that it can be up to date on the docs repository 😇:

cargo make docs-generate

@egasimus
Copy link
Contributor Author

egasimus commented Sep 8, 2023

Done! 😄

Copy link
Member

@amimart amimart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx! 🙏

Copy link
Member

@ccamel ccamel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 Thanks

@ccamel ccamel assigned amimart and bdeneux and unassigned ccamel Sep 8, 2023
Copy link
Contributor

@bdeneux bdeneux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙏!

@amimart amimart merged commit b669c07 into axone-protocol:main Sep 8, 2023
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants