fix: calculation order change

[yevhen-burkovskyi]

No description provided.

[coderabbitai]

Walkthrough

The changes involve modifying the SupplyChangeDto interface to store the properties change, burnt, and issuance as strings instead of numbers. Additionally, the logic in the SupplyService class has been updated to handle these values as strings and apply precision formatting.

Changes

File Path	Change Summary
src/modules/supply/dtos/supply-change.dto.ts	Updated SupplyChangeDto properties (change, burnt, issuance) from number to string.
src/modules/supply/services/supply.service.ts	Updated the SupplyService to handle string values for computation and apply precision formatting.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 80e20f5 and d9fe10c.

Files selected for processing (2)

• src/modules/supply/dtos/supply-change.dto.ts (1 hunks)
• src/modules/supply/services/supply.service.ts (1 hunks)

Additional comments not posted (8)

src/modules/supply/dtos/supply-change.dto.ts (3)

3-3: Type change approved for change property.

The change property type is updated from number to string to handle values as strings for precision formatting.

---

4-4: Type change approved for burnt property.

The burnt property type is updated from number to string to handle values as strings for precision formatting.

---

5-5: Type change approved for issuance property.

The issuance property type is updated from number to string to handle values as strings for precision formatting.

src/modules/supply/services/supply.service.ts (5)

145-145: Initialization of change as a string approved.

The change property is initialized as a string with value '0', aligning with the updated type.

---

146-146: Initialization of burnt as a string approved.

The burnt property is initialized as a string with value '0', aligning with the updated type.

---

147-147: Initialization of issuance as a string approved.

The issuance property is initialized as a string with value '0', aligning with the updated type.

---

152-152: Precision formatting for issuance approved.

The issuance is calculated using toFixed(2) for precision, ensuring it is formatted as a string with two decimal places.

---

153-153: Precision formatting for change approved.

The change is calculated using string-based arithmetic with toFixed(2) for precision, ensuring it is formatted as a string with two decimal places.