Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

108 review the new GitHub attestations #448

Closed
wants to merge 9 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 24 additions & 2 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,14 @@ defaults:
run:
shell: bash

permissions:
id-token: write
attestations: write
contents: write
packages: write
pull-requests: read
deployments: read

jobs:
build:
name: Build on ${{ matrix.target }}
Expand Down Expand Up @@ -163,8 +171,8 @@ jobs:
- name: Build signed installer
if: runner.os == 'Windows'
run: |
azuresigntool.exe sign --verbose -kvu ${{ secrets.AZURE_KEY_VAULT_URI }} -kvc ${{ secrets.AZURE_KEYVAULT_CERT_NAME }} -kva %AZ_TOKEN% -fd sha256 -tr http://timestamp.digicert.com -v "dist/AxonOps Workbench-%GITHUB_REF_NAME%-win-x64.exe"
azuresigntool.exe sign --verbose -kvu ${{ secrets.AZURE_KEY_VAULT_URI }} -kvc ${{ secrets.AZURE_KEYVAULT_CERT_NAME }} -kva %AZ_TOKEN% -fd sha256 -tr http://timestamp.digicert.com -v "dist/AxonOps Workbench-%GITHUB_REF_NAME%-win-x64.msi"
azuresigntool.exe sign --verbose -kvu ${{ secrets.AZURE_KEY_VAULT_URI }} -kvc ${{ secrets.AZURE_KEYVAULT_CERT_NAME }} -kva %AZ_TOKEN% -fd sha256 -tr http://timestamp.digicert.com -v "dist/AxonOps.Workbench-%GITHUB_REF_NAME%-win-x64.exe"
azuresigntool.exe sign --verbose -kvu ${{ secrets.AZURE_KEY_VAULT_URI }} -kvc ${{ secrets.AZURE_KEYVAULT_CERT_NAME }} -kva %AZ_TOKEN% -fd sha256 -tr http://timestamp.digicert.com -v "dist/AxonOps.Workbench-%GITHUB_REF_NAME%-win-x64.msi"
shell: cmd

# Ensure this task is right before the Upload
Expand Down Expand Up @@ -217,6 +225,20 @@ jobs:
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

- name: Attest Build Provenance for TGZ
uses: actions/attest-build-provenance@897ed5eab6ed058a474202017ada7f40bfa52940 # v1.0.0
with:
subject-path: |
dist/*.zip
dist/*.pkg
dist/*.dmg
dist/*.deb
dist/*.rpm
dist/*.exe
dist/*.tar.gz
dist/*.nsis
dist/*.msi

# Release choco and brew

release-brew:
Expand Down
28 changes: 28 additions & 0 deletions .github/workflows/trivy.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
name: build
on:
push:
branches:
- main
pull_request:
jobs:
build:
name: Run Trivy
runs-on: ubuntu-22.04
steps:
- name: Checkout code
uses: actions/checkout@v3

- name: Run Trivy vulnerability scanner in repo mode
uses: aquasecurity/trivy-action@6e7b7d1fd3e4fef0c5fa8cce1229c54b2c9bd0d8 # 0.24.0
with:
scan-type: 'fs'
ignore-unfixed: true
format: 'sarif'
output: 'trivy-results.sarif'
severity: "MEDIUM,HIGH,CRITICAL"
#scanners: "vuln"

- name: Upload Trivy scan results to GitHub Security tab
uses: github/codeql-action/upload-sarif@v2
with:
sarif_file: 'trivy-results.sarif'
6 changes: 3 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -30,14 +30,14 @@
"provider": "github"
}
],
"artifactName": "${productName}-${version}-${os}-${arch}.${ext}",
"artifactName": "AxonOps.Workbench-${version}-${os}-${arch}.${ext}",
"win": {
"icon": "./renderer/assets/images/axonops-icon-256x256.ico",
"target": [
"nsis",
"msi"
],
"artifactName": "${productName}-${version}-${os}-${arch}.${ext}"
"artifactName": "AxonOps.Workbench-${version}-${os}-${arch}.${ext}"
},
"linux": {
"icon": "./renderer/assets/images/",
Expand All @@ -49,7 +49,7 @@
"Keywords": "cassandra;axonops;development;workbench",
"Icon": "/usr/share/icons/hicolor/256x256/apps/axonops-workbench.png"
},
"artifactName": "${productName}-${version}-${os}-${arch}.${ext}"
"artifactName": "AxonOps.Workbench-${version}-${os}-${arch}.${ext}"
},
"mac": {
"icon": "./renderer/assets/images/axonops-icon-512x512.icns",
Expand Down
Loading