Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

az-digital/az-icons#17: Update icon font with vimeo icon #1464

Merged
merged 2 commits into from
Apr 15, 2022

Conversation

trackleft
Copy link
Member

@trackleft trackleft commented Apr 8, 2022

Description

Adding updated icon font
renamed: png/pintrest.png -> png/pinterest.png
deleted: .gitignore
modified: az-icons-styles.css
modified: fonts/az-icons.eot
modified: fonts/az-icons.svg
modified: fonts/az-icons.ttf
modified: fonts/az-icons.woff
renamed: png/pintrest.png -> png/pinterest.png
new file: png/vimeo.png
new file: svg/vimeo.svg
deleted: "png/Icon\r"

Related issues

#add vimeo icon

How to test

Enable global footer add icons to menu.

Arizona Quickstart (install profile, custom modules, custom theme)

  • Patch release changes
    • Bug fix
    • Accessibility, performance, or security improvement
    • Critical institutional link or brand change
  • Minor release changes
    • New feature
    • Breaking or visual change to existing behavior
    • Non-critical brand change
    • New internal API or API improvement with backwards compatibility
    • Risky or disruptive cleanup to comply with coding standards
    • High-risk or disruptive change (requires upgrade path, risks regression, etc.)
  • Other or unknown

Drupal core

  • Patch release changes
    • Security update
    • Patch level release (non-security bug-fix release)
    • Patch removal that's no longer necessary
  • Minor release changes
    • Major or minor level update
  • Other or unknown

Drupal contrib projects

  • Patch release changes
    • Security update
    • Patch or minor level update
    • Add new module
    • Patch removal that's no longer necessary
  • Minor release changes
    • Major level update
  • Other or unknown

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@trackleft trackleft requested a review from a team as a code owner April 8, 2022 19:51
@trackleft trackleft self-assigned this Apr 8, 2022
@trackleft trackleft added bug Something isn't working backport Changes to be back-ported to previous minor release branch labels Apr 8, 2022
@michaelhagedon
Copy link
Contributor

Quickstart has its own copy of az-icons? (Sorry if this came up in discussion today -- I was definitely multi-tasking...)

@trackleft trackleft marked this pull request as draft April 8, 2022 20:32
@camikazegreen
Copy link
Contributor

@michaelhagedon It does for now. See az-digital/az-icons#22 for a potential fix to that.

@trackleft
Copy link
Member Author

Yes there is a config setting for az_barrio that allows switching between remote or local
For better performance, local is desired supposedly
Also, if the cdn ever goes down you should be able to switch to local
image

@michaelhagedon
Copy link
Contributor

Ah, thanks, yeah I just found that setting too. I was just surprised -- we got the vimeo icon as soon as it was merged, but we're set to external.

That local setting is a bit of extra work!

@trackleft
Copy link
Member Author

Ah, thanks, yeah I just found that setting too. I was just surprised -- we got the vimeo icon as soon as it was merged, but we're set to external.

That local setting is a bit of extra work!

The things we do to eek out performance and stability.

@trackleft trackleft marked this pull request as ready for review April 8, 2022 21:27
@trackleft
Copy link
Member Author

trackleft commented Apr 8, 2022

This works https://7b5e2985-cedf-4a13-ab91-3a35916c835d--pr-1464.probo.build/. I'm using the local copy.

image

image

@joeparsons joeparsons changed the title Update icon font with vimeo icon az-digital/az-icons#17: Update icon font with vimeo icon Apr 13, 2022
@joeparsons joeparsons added the patch release Issues to be included in the next patch release label Apr 15, 2022
@joeparsons joeparsons merged commit b7b18a6 into main Apr 15, 2022
@joeparsons joeparsons deleted the issue/az-icons-17-add-vimeo-icon branch April 15, 2022 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Changes to be back-ported to previous minor release branch bug Something isn't working patch release Issues to be included in the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants