Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #3793: Improve accessibility of card link titles #3814

Merged
merged 16 commits into from
Oct 25, 2024
Merged

Conversation

joeparsons
Copy link
Member

@joeparsons joeparsons commented Oct 23, 2024

Description

  • Adds a new "Hidden" card link tltle style option (sr-only)
  • Adds validation to the card link title to require a value of a card link URL value is provided

Release notes

This change makes the Card Link Title field required if the Card Link URL field is populated.

Related issues

Closes #3793

How to test

Try adding cards to flexible pages using different title style options with and without card link title and card link URL values.

  1. Add cards to a page
  2. Test clickable and non-clickable card style with the following options
    a. With/out Card Link Title field
    b. With/out Card Link URL field
  3. Repeat with title on image vs title within card styles

Types of changes

Arizona Quickstart (install profile, custom modules, custom theme)

  • Patch release changes
    • Bug fix
    • Accessibility, performance, or security improvement
    • Critical institutional link or brand change
    • Adding experimental module
    • Update experimental module
  • Minor release changes
    • New feature
    • Breaking or visual change to existing behavior
    • Upgrade experimental module to stable
    • Enable existing module by default or database update
    • Non-critical brand change
    • New internal API or API improvement with backwards compatibility
    • Risky or disruptive cleanup to comply with coding standards
    • High-risk or disruptive change (requires upgrade path, risks regression, etc.)
  • Other or unknown
    • Other or unknown

Drupal core

  • Patch release changes
    • Security update
    • Patch level release (non-security bug-fix release)
    • Patch removal that's no longer necessary
  • Minor release changes
    • Major or minor level update
  • Other or unknown
    • Other or unknown

Drupal contrib projects

  • Patch release changes
    • Security update
    • Patch or minor level update
    • Add new module
    • Patch removal that's no longer necessary
  • Minor release changes
    • Major level update
  • Other or unknown
    • Other or unknown

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My change requires release notes.

@joeparsons joeparsons added bug Something isn't working enhancement New feature or request accessibility labels Oct 23, 2024
@joeparsons joeparsons linked an issue Oct 23, 2024 that may be closed by this pull request
@joeparsons joeparsons changed the title Closes #3793: Fix card link title accessibility Closes #3793: Improve card link title accessibility Oct 24, 2024
@joeparsons joeparsons changed the title Closes #3793: Improve card link title accessibility Closes #3793: Improve accessibility of card link titles Oct 24, 2024
@joeparsons joeparsons marked this pull request as ready for review October 24, 2024 22:56
@joeparsons joeparsons requested a review from a team as a code owner October 24, 2024 22:56
@danahertzberg
Copy link
Contributor

danahertzberg commented Oct 25, 2024

When the following selections are made, the link does not span the whole card.

* Clickable card
* Card link title and URL fields populated
* Hidden card link title

Example: https://7b5e2985-cedf-4a13-ab91-3a35916c835d--pr-3814.probo.build/dana
image


Fixed with CSS

Copy link
Contributor

@danahertzberg danahertzberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will make a follow up ticket for the # link going to the homepage instead of the current page

Copy link

@ewlyman ewlyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works as described.

@danahertzberg
Copy link
Contributor

danahertzberg commented Oct 25, 2024

Current needs

  • Solid communication around updating content on sites

Will look into DB update for future

  • If no link title, make card title and select hidden link title
  • If no card title, TBD
    • Get title of destination link? Probs not

Future

  • Look into providing accessibility report on the site admin side
  • How do we communicate and fix issues easily across whole site?
    • Jeff is willing to help with this cause to be more proactive

@danahertzberg danahertzberg added the needs-CWS-testing Needs manual pre/post release testing by Campus Web Services label Oct 25, 2024
@trackleft trackleft merged commit 690599c into main Oct 25, 2024
15 of 16 checks passed
@trackleft trackleft deleted the issue/3793 branch October 25, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.12.x only accessibility bug Something isn't working enhancement New feature or request needs-CWS-testing Needs manual pre/post release testing by Campus Web Services release notes
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Improve accessibility of card link titles
4 participants