Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #3869: Enhance resolution of images for Marketing Cloud emails #3879

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

danahertzberg
Copy link
Contributor

@danahertzberg danahertzberg commented Nov 14, 2024

Description

This increases the resolution of images used in Marketing Cloud

Release notes

Related issues

Closes #3869

How to test

  1. Enable az_marketing_cloud
  2. View news layout for Marketing Cloud
  3. Compare image resolution between this PR and other site to ensure higher image resolution

Types of changes

Arizona Quickstart (install profile, custom modules, custom theme)

  • Patch release changes
    • Bug fix
    • Accessibility, performance, or security improvement
    • Critical institutional link or brand change
    • Adding experimental module
    • Update experimental module
  • Minor release changes
    • New feature
    • Breaking or visual change to existing behavior
    • Upgrade experimental module to stable
    • Enable existing module by default or database update
    • Non-critical brand change
    • New internal API or API improvement with backwards compatibility
    • Risky or disruptive cleanup to comply with coding standards
    • High-risk or disruptive change (requires upgrade path, risks regression, etc.)
  • Other or unknown
    • Other or unknown

Drupal core

  • Patch release changes
    • Security update
    • Patch level release (non-security bug-fix release)
    • Patch removal that's no longer necessary
  • Minor release changes
    • Major or minor level update
  • Other or unknown
    • Other or unknown

Drupal contrib projects

  • Patch release changes
    • Security update
    • Patch or minor level update
    • Add new module
    • Patch removal that's no longer necessary
  • Minor release changes
    • Major level update
  • Other or unknown
    • Other or unknown

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My change requires release notes.

@danahertzberg danahertzberg added backport Changes to be back-ported to previous minor release branch editor experience Improvements to the editor experience for individuals editing Quickstart websites labels Nov 14, 2024
@danahertzberg danahertzberg self-assigned this Nov 14, 2024
@danahertzberg danahertzberg requested a review from a team as a code owner November 14, 2024 21:34
@danahertzberg danahertzberg linked an issue Nov 14, 2024 that may be closed by this pull request
@danahertzberg
Copy link
Contributor Author

danahertzberg commented Nov 15, 2024

Does an existing site with Marketing Cloud enabled force this image style to regenerate images?

  • Need to test on existing site before merging

@danahertzberg
Copy link
Contributor Author

Looking great!

Compare multidev to live
Screenshot 2024-11-19 at 9 17 34 AM

Copy link
Contributor

@ejsamboy ejsamboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I compared the image resolution between this PR and one of my testing sites. The PR has a higher image resolution. PR-better resolution
test-site

Copy link
Contributor

@bberndt-uaz bberndt-uaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danahertzberg This looks good to me, but do you think it would be good to update the values in the twig templates as well? I imagine that we want to keep the images the same size, but certain widths could still be updated to the correct value for the image, such as width="200" here: https://github.com/az-digital/az_quickstart/blob/main/modules/custom/az_marketing_cloud/templates/node--view--az-marketing-cloud--30-70-layout.html.twig#L86.

@danahertzberg
Copy link
Contributor Author

@danahertzberg This looks good to me, but do you think it would be good to update the values in the twig templates as well? I imagine that we want to keep the images the same size, but certain widths could still be updated to the correct value for the image, such as width="200" here: https://github.com/az-digital/az_quickstart/blob/main/modules/custom/az_marketing_cloud/templates/node--view--az-marketing-cloud--30-70-layout.html.twig#L86.

We definitely want to keep the widths defined in the template as to not change the layout style.

@joeparsons joeparsons added the patch release Issues to be included in the next patch release label Nov 20, 2024
@danahertzberg
Copy link
Contributor Author

Look at imagemagick configuration for use in this case

@danahertzberg
Copy link
Contributor Author

Testing sites

Resulting email I'm not seeing any difference between the original and image magick versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Changes to be back-ported to previous minor release branch editor experience Improvements to the editor experience for individuals editing Quickstart websites patch release Issues to be included in the next patch release
Projects
Status: Ready to merge
Status: Ready to merge
Development

Successfully merging this pull request may close these issues.

Allower higher resolution images in Marketing Cloud emails
4 participants