-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes #3869: Enhance resolution of images for Marketing Cloud emails #3879
base: main
Are you sure you want to change the base?
Conversation
Does an existing site with Marketing Cloud enabled force this image style to regenerate images?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@danahertzberg This looks good to me, but do you think it would be good to update the values in the twig templates as well? I imagine that we want to keep the images the same size, but certain widths could still be updated to the correct value for the image, such as width="200"
here: https://github.com/az-digital/az_quickstart/blob/main/modules/custom/az_marketing_cloud/templates/node--view--az-marketing-cloud--30-70-layout.html.twig#L86.
We definitely want to keep the widths defined in the template as to not change the layout style. |
Look at imagemagick configuration for use in this case |
Testing sites Resulting email I'm not seeing any difference between the original and image magick versions. |
Description
This increases the resolution of images used in Marketing Cloud
Release notes
Related issues
Closes #3869
How to test
Types of changes
Arizona Quickstart (install profile, custom modules, custom theme)
Drupal core
Drupal contrib projects
Checklist