Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update drupal/metatag requirement from 2.0.2 to 2.1.0 #3880

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 14, 2024

Updates the requirements on drupal/metatag to permit the latest version.

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot requested a review from a team as a code owner November 14, 2024 22:02
@dependabot dependabot bot added dependencies Pull requests that update a dependency file php Pull requests that update Php code labels Nov 14, 2024
@bberndt-uaz
Copy link
Contributor

https://www.drupal.org/project/metatag/releases/2.1.0

Release notes

This is the first release of the 2.1.x branch and includes several new features, and full compatibility with Drupal 11. Thanks to everyone for collaborating on the improvements.

Future changes on this branch will be focused on bug fixes, new features will go into the 2.2.x branch.

Changes since 2.0.2:

Bug

Feature

Task

@bberndt-uaz bberndt-uaz added the Drupal Waiting on a fix from the Drupal community label Nov 14, 2024
@joeparsons joeparsons added the patch release Issues to be included in the next patch release label Nov 18, 2024
@bberndt-uaz
Copy link
Contributor

bberndt-uaz commented Nov 18, 2024

In Probo, I confirmed that the meta tags are working properly, but I get an error when I try to save the Front Page or Content meta tag defaults:

**Error message**

**Deprecated function: mb_strtolower(): Passing null to parameter #1 ($string) of type string is deprecated in Drupal\Core\Config\Entity\Query\Condition->compile() (line 39 of core/lib/Drupal/Core/Config/Entity/Query/Condition.php).**

#0 /src/az-quickstart-scaffolding/web/core/includes/bootstrap.inc(166): _drupal_error_handler_real()
#1 [internal function]: _drupal_error_handler()
#2 /src/az-quickstart-scaffolding/web/core/lib/Drupal/Core/Config/Entity/Query/Condition.php(39): mb_strtolower()
#3 /src/az-quickstart-scaffolding/web/core/lib/Drupal/Core/Config/Entity/Query/Query.php(88): Drupal\Core\Config\Entity\Query\Condition->compile()
#4 /src/az-quickstart-scaffolding/web/core/lib/Drupal/Core/Config/Entity/ConfigEntityBase.php(307): Drupal\Core\Config\Entity\Query\Query->execute()
#5 /src/az-quickstart-scaffolding/web/core/lib/Drupal/Core/Entity/EntityStorageBase.php(528): Drupal\Core\Config\Entity\ConfigEntityBase->preSave()
#6 /src/az-quickstart-scaffolding/web/core/lib/Drupal/Core/Entity/EntityStorageBase.php(483): Drupal\Core\Entity\EntityStorageBase->doPreSave()
#7 /src/az-quickstart-scaffolding/web/core/lib/Drupal/Core/Config/Entity/ConfigEntityStorage.php(257): Drupal\Core\Entity\EntityStorageBase->save()
#8 /src/az-quickstart-scaffolding/web/core/lib/Drupal/Core/Entity/EntityBase.php(354): Drupal\Core\Config\Entity\ConfigEntityStorage->save()
#9 /src/az-quickstart-scaffolding/web/core/lib/Drupal/Core/Config/Entity/ConfigEntityBase.php(614): Drupal\Core\Entity\EntityBase->save()
#10 /src/az-quickstart-scaffolding/web/modules/contrib/metatag/src/Form/MetatagDefaultsForm.php(294): Drupal\Core\Config\Entity\ConfigEntityBase->save()
#11 [internal function]: Drupal\metatag\Form\MetatagDefaultsForm->save()
#12 /src/az-quickstart-scaffolding/web/core/lib/Drupal/Core/Form/FormSubmitter.php(129): call_user_func_array()
#13 /src/az-quickstart-scaffolding/web/core/lib/Drupal/Core/Form/FormSubmitter.php(67): Drupal\Core\Form\FormSubmitter->executeSubmitHandlers()
#14 /src/az-quickstart-scaffolding/web/core/lib/Drupal/Core/Form/FormBuilder.php(597): Drupal\Core\Form\FormSubmitter->doSubmitForm()
#15 /src/az-quickstart-scaffolding/web/core/lib/Drupal/Core/Form/FormBuilder.php(326): Drupal\Core\Form\FormBuilder->processForm()
#16 /src/az-quickstart-scaffolding/web/core/lib/Drupal/Core/Controller/FormController.php(73): Drupal\Core\Form\FormBuilder->buildForm()
#17 [internal function]: Drupal\Core\Controller\FormController->getContentResult()
#18 /src/az-quickstart-scaffolding/web/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php(123): call_user_func_array()
#19 /src/az-quickstart-scaffolding/web/core/lib/Drupal/Core/Render/Renderer.php(638): Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}()
#20 /src/az-quickstart-scaffolding/web/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php(121): Drupal\Core\Render\Renderer->executeInRenderContext()
#21 /src/az-quickstart-scaffolding/web/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php(97): Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext()
#22 /src/az-quickstart-scaffolding/vendor/symfony/http-kernel/HttpKernel.php(181): Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}()
#23 /src/az-quickstart-scaffolding/vendor/symfony/http-kernel/HttpKernel.php(76): Symfony\Component\HttpKernel\HttpKernel->handleRaw()
#24 /src/az-quickstart-scaffolding/web/core/lib/Drupal/Core/StackMiddleware/Session.php(53): Symfony\Component\HttpKernel\HttpKernel->handle()
#25 /src/az-quickstart-scaffolding/web/core/lib/Drupal/Core/StackMiddleware/KernelPreHandle.php(48): Drupal\Core\StackMiddleware\Session->handle()
#26 /src/az-quickstart-scaffolding/web/core/lib/Drupal/Core/StackMiddleware/ContentLength.php(28): Drupal\Core\StackMiddleware\KernelPreHandle->handle()
#27 /src/az-quickstart-scaffolding/web/core/modules/big_pipe/src/StackMiddleware/ContentLength.php(32): Drupal\Core\StackMiddleware\ContentLength->handle()
#28 /src/az-quickstart-scaffolding/web/core/modules/page_cache/src/StackMiddleware/PageCache.php(106): Drupal\big_pipe\StackMiddleware\ContentLength->handle()
#29 /src/az-quickstart-scaffolding/web/core/modules/page_cache/src/StackMiddleware/PageCache.php(85): Drupal\page_cache\StackMiddleware\PageCache->pass()
#30 /src/az-quickstart-scaffolding/web/core/lib/Drupal/Core/StackMiddleware/ReverseProxyMiddleware.php(48): Drupal\page_cache\StackMiddleware\PageCache->handle()
#31 /src/az-quickstart-scaffolding/web/core/lib/Drupal/Core/StackMiddleware/NegotiationMiddleware.php(51): Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle()
#32 /src/az-quickstart-scaffolding/web/core/lib/Drupal/Core/StackMiddleware/AjaxPageState.php(36): Drupal\Core\StackMiddleware\NegotiationMiddleware->handle()
#33 /src/az-quickstart-scaffolding/web/core/lib/Drupal/Core/StackMiddleware/StackedHttpKernel.php(51): Drupal\Core\StackMiddleware\AjaxPageState->handle()
#34 /src/az-quickstart-scaffolding/web/core/lib/Drupal/Core/DrupalKernel.php(741): Drupal\Core\StackMiddleware\StackedHttpKernel->handle()
#35 /src/az-quickstart-scaffolding/web/index.php(19): Drupal\Core\DrupalKernel->handle()
#36 {main}

I don't get the error when saving the settings for any of the other types. I'm not sure of the cause of this error. I confirmed that it does not occur with Metatag 2.0.2.

@joeparsons
Copy link
Member

In Probo, I confirmed that the meta tags are working properly, but I get an error when I try to save the Front Page or Content meta tag defaults:

...

I don't get the error when saving the settings for any of the other types. I'm not sure of the cause of this error. I confirmed that it does not occur with Metatag 2.0.2.

That error sounds like the one this core issue is about:
https://www.drupal.org/project/drupal/issues/3302838

Updates the requirements on drupal/metatag to permit the latest version.

---
updated-dependencies:
- dependency-name: drupal/metatag
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/composer/drupal/metatag-2.1.0 branch from 08f9e61 to e88fd80 Compare December 6, 2024 19:19
@joeparsons
Copy link
Member

In Probo, I confirmed that the meta tags are working properly, but I get an error when I try to save the Front Page or Content meta tag defaults:

**Error message**

**Deprecated function: mb_strtolower(): Passing null to parameter #1 ($string) of type string is deprecated in Drupal\Core\Config\Entity\Query\Condition->compile() (line 39 of core/lib/Drupal/Core/Config/Entity/Query/Condition.php).**

#0 /src/az-quickstart-scaffolding/web/core/includes/bootstrap.inc(166): _drupal_error_handler_real()
#1 [internal function]: _drupal_error_handler()
#2 /src/az-quickstart-scaffolding/web/core/lib/Drupal/Core/Config/Entity/Query/Condition.php(39): mb_strtolower()
#3 /src/az-quickstart-scaffolding/web/core/lib/Drupal/Core/Config/Entity/Query/Query.php(88): Drupal\Core\Config\Entity\Query\Condition->compile()
#4 /src/az-quickstart-scaffolding/web/core/lib/Drupal/Core/Config/Entity/ConfigEntityBase.php(307): Drupal\Core\Config\Entity\Query\Query->execute()
#5 /src/az-quickstart-scaffolding/web/core/lib/Drupal/Core/Entity/EntityStorageBase.php(528): Drupal\Core\Config\Entity\ConfigEntityBase->preSave()
#6 /src/az-quickstart-scaffolding/web/core/lib/Drupal/Core/Entity/EntityStorageBase.php(483): Drupal\Core\Entity\EntityStorageBase->doPreSave()
#7 /src/az-quickstart-scaffolding/web/core/lib/Drupal/Core/Config/Entity/ConfigEntityStorage.php(257): Drupal\Core\Entity\EntityStorageBase->save()
#8 /src/az-quickstart-scaffolding/web/core/lib/Drupal/Core/Entity/EntityBase.php(354): Drupal\Core\Config\Entity\ConfigEntityStorage->save()
#9 /src/az-quickstart-scaffolding/web/core/lib/Drupal/Core/Config/Entity/ConfigEntityBase.php(614): Drupal\Core\Entity\EntityBase->save()
#10 /src/az-quickstart-scaffolding/web/modules/contrib/metatag/src/Form/MetatagDefaultsForm.php(294): Drupal\Core\Config\Entity\ConfigEntityBase->save()
#11 [internal function]: Drupal\metatag\Form\MetatagDefaultsForm->save()
#12 /src/az-quickstart-scaffolding/web/core/lib/Drupal/Core/Form/FormSubmitter.php(129): call_user_func_array()
#13 /src/az-quickstart-scaffolding/web/core/lib/Drupal/Core/Form/FormSubmitter.php(67): Drupal\Core\Form\FormSubmitter->executeSubmitHandlers()
#14 /src/az-quickstart-scaffolding/web/core/lib/Drupal/Core/Form/FormBuilder.php(597): Drupal\Core\Form\FormSubmitter->doSubmitForm()
#15 /src/az-quickstart-scaffolding/web/core/lib/Drupal/Core/Form/FormBuilder.php(326): Drupal\Core\Form\FormBuilder->processForm()
#16 /src/az-quickstart-scaffolding/web/core/lib/Drupal/Core/Controller/FormController.php(73): Drupal\Core\Form\FormBuilder->buildForm()
#17 [internal function]: Drupal\Core\Controller\FormController->getContentResult()
#18 /src/az-quickstart-scaffolding/web/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php(123): call_user_func_array()
#19 /src/az-quickstart-scaffolding/web/core/lib/Drupal/Core/Render/Renderer.php(638): Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}()
#20 /src/az-quickstart-scaffolding/web/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php(121): Drupal\Core\Render\Renderer->executeInRenderContext()
#21 /src/az-quickstart-scaffolding/web/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php(97): Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext()
#22 /src/az-quickstart-scaffolding/vendor/symfony/http-kernel/HttpKernel.php(181): Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}()
#23 /src/az-quickstart-scaffolding/vendor/symfony/http-kernel/HttpKernel.php(76): Symfony\Component\HttpKernel\HttpKernel->handleRaw()
#24 /src/az-quickstart-scaffolding/web/core/lib/Drupal/Core/StackMiddleware/Session.php(53): Symfony\Component\HttpKernel\HttpKernel->handle()
#25 /src/az-quickstart-scaffolding/web/core/lib/Drupal/Core/StackMiddleware/KernelPreHandle.php(48): Drupal\Core\StackMiddleware\Session->handle()
#26 /src/az-quickstart-scaffolding/web/core/lib/Drupal/Core/StackMiddleware/ContentLength.php(28): Drupal\Core\StackMiddleware\KernelPreHandle->handle()
#27 /src/az-quickstart-scaffolding/web/core/modules/big_pipe/src/StackMiddleware/ContentLength.php(32): Drupal\Core\StackMiddleware\ContentLength->handle()
#28 /src/az-quickstart-scaffolding/web/core/modules/page_cache/src/StackMiddleware/PageCache.php(106): Drupal\big_pipe\StackMiddleware\ContentLength->handle()
#29 /src/az-quickstart-scaffolding/web/core/modules/page_cache/src/StackMiddleware/PageCache.php(85): Drupal\page_cache\StackMiddleware\PageCache->pass()
#30 /src/az-quickstart-scaffolding/web/core/lib/Drupal/Core/StackMiddleware/ReverseProxyMiddleware.php(48): Drupal\page_cache\StackMiddleware\PageCache->handle()
#31 /src/az-quickstart-scaffolding/web/core/lib/Drupal/Core/StackMiddleware/NegotiationMiddleware.php(51): Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle()
#32 /src/az-quickstart-scaffolding/web/core/lib/Drupal/Core/StackMiddleware/AjaxPageState.php(36): Drupal\Core\StackMiddleware\NegotiationMiddleware->handle()
#33 /src/az-quickstart-scaffolding/web/core/lib/Drupal/Core/StackMiddleware/StackedHttpKernel.php(51): Drupal\Core\StackMiddleware\AjaxPageState->handle()
#34 /src/az-quickstart-scaffolding/web/core/lib/Drupal/Core/DrupalKernel.php(741): Drupal\Core\StackMiddleware\StackedHttpKernel->handle()
#35 /src/az-quickstart-scaffolding/web/index.php(19): Drupal\Core\DrupalKernel->handle()
#36 {main}

I don't get the error when saving the settings for any of the other types. I'm not sure of the cause of this error. I confirmed that it does not occur with Metatag 2.0.2.

I was unable to reproduce these errors on a non-Quickstart Drupal 10.3.9 / Metatag 2.1.0 site install.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file Drupal Waiting on a fix from the Drupal community patch release Issues to be included in the next patch release php Pull requests that update Php code
Projects
Status: Needs review
Status: Needs review
Development

Successfully merging this pull request may close these issues.

2 participants