Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alternate PR for #3644: Adds schema_metatag patch from d.o. MR. #3901

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

joeparsons
Copy link
Member

@joeparsons joeparsons commented Nov 21, 2024

Description

Release notes

Related issues

How to test

  • Install schema_metatag and schema_organization modules

Types of changes

Arizona Quickstart (install profile, custom modules, custom theme)

  • Patch release changes
    • Bug fix
    • Accessibility, performance, or security improvement
    • Critical institutional link or brand change
    • Adding experimental module
    • Update experimental module
  • Minor release changes
    • New feature
    • Breaking or visual change to existing behavior
    • Upgrade experimental module to stable
    • Enable existing module by default or database update
    • Non-critical brand change
    • New internal API or API improvement with backwards compatibility
    • Risky or disruptive cleanup to comply with coding standards
    • High-risk or disruptive change (requires upgrade path, risks regression, etc.)
  • Other or unknown
    • Other or unknown

Drupal core

  • Patch release changes
    • Security update
    • Patch level release (non-security bug-fix release)
    • Patch removal that's no longer necessary
  • Minor release changes
    • Major or minor level update
  • Other or unknown
    • Other or unknown

Drupal contrib projects

  • Patch release changes
    • Security update
    • Patch or minor level update
    • Add new module
    • Patch removal that's no longer necessary
  • Minor release changes
    • Major level update
  • Other or unknown
    • Other or unknown

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My change requires release notes.

@joeparsons joeparsons changed the base branch from main to 3903-add-schema_metatag-module-to-quickstarts-composer-file-and-as-a-dependency-for-az_seo November 21, 2024 20:46
…file-and-as-a-dependency-for-az_seo' into issue/3644-alt
@joeparsons joeparsons changed the title Alternate PR for #3644: Adds schema_metatag module + patch from d.o. MR. Alternate PR for #3644: Adds schema_metatag patch from d.o. MR. Nov 21, 2024
@joeparsons joeparsons linked an issue Nov 21, 2024 that may be closed by this pull request
4 tasks
@trackleft
Copy link
Member

I think this PR should enable schema_organization and set global defaults.

Base automatically changed from 3903-add-schema_metatag-module-to-quickstarts-composer-file-and-as-a-dependency-for-az_seo to main November 22, 2024 18:13
@trackleft
Copy link
Member

Recommended metatag.metatag_defaults.global.yml

langcode: en
status: true
dependencies: {  }
id: global
label: Global
tags:
  canonical_url: '[current-page:url]'
  schema_organization_name: '[site:name]'
  schema_organization_parent_organization: 'a:6:{s:5:"@type";s:23:"EducationalOrganization";s:3:"@id";s:24:"https://www.arizona.edu/";s:4:"name";s:21:"University of Arizona";s:3:"url";s:24:"https://www.arizona.edu/";s:6:"sameAs";s:240:"https://www.facebook.com/uarizona,https://x.com/uarizona,https://www.instagram.com/uarizona,https://linkedin.com/edu/university-of-arizona-17783,https://www.youtube.com/universityofarizona,https://en.wikipedia.org/wiki/University_of_Arizona";s:7:"address";a:6:{s:5:"@type";s:13:"PostalAddress";s:13:"streetAddress";s:22:"1200 E University Blvd";s:15:"addressLocality";s:6:"Tucson";s:13:"addressRegion";s:2:"AZ";s:10:"postalCode";s:5:"85721";s:14:"addressCountry";s:2:"US";}}'
  title: '[current-page:title] | [site:name]'

@RyanDool
Copy link
Contributor

RyanDool commented Dec 6, 2024

Recommended metatag.metatag_defaults.global.yml

langcode: en
status: true
dependencies: {  }
id: global
label: Global
tags:
  canonical_url: '[current-page:url]'
  schema_organization_name: '[site:name]'
  schema_organization_parent_organization: 'a:6:{s:5:"@type";s:23:"EducationalOrganization";s:3:"@id";s:24:"https://www.arizona.edu/";s:4:"name";s:21:"University of Arizona";s:3:"url";s:24:"https://www.arizona.edu/";s:6:"sameAs";s:240:"https://www.facebook.com/uarizona,https://x.com/uarizona,https://www.instagram.com/uarizona,https://linkedin.com/edu/university-of-arizona-17783,https://www.youtube.com/universityofarizona,https://en.wikipedia.org/wiki/University_of_Arizona";s:7:"address";a:6:{s:5:"@type";s:13:"PostalAddress";s:13:"streetAddress";s:22:"1200 E University Blvd";s:15:"addressLocality";s:6:"Tucson";s:13:"addressRegion";s:2:"AZ";s:10:"postalCode";s:5:"85721";s:14:"addressCountry";s:2:"US";}}'
  title: '[current-page:title] | [site:name]'

I agree that should be done. Maybe not in this PR since its out of scope of the original request but it should definitely be done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set schema_metatag global defaults for az_quickstart Using the az_seo Module
4 participants