Revert AWS CLI upgrade and temporarily disable Tilegarden deployment #844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Tilegarden package has gotten too big. We haven't changed anything, so it has to be that the dependencies grew. But we need to figure out how to shrink them again to get it to deploy. Fortunately we can just keep the old one up until we've done that. So this comments out the command in 'infra' where we try to redeploy it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Two issues came up when the CI server was trying to deploy the post-PR #842 develop branch to staging.
The first was related to #823 (comment). Upgrading the AWS CLI turned out not to be essential for getting the deployment working, and since the CI server still has v1, it actually made matters worse. So this switches back to the old setup and changes the command in
cipublishto make it not crash.The other is that the Lambda deployment package for the Tilegarden service exceeds the size limit. Since we haven't changed anything, that has to be because something changed in the dependencies. I opened #843, and for now I commented the Tilegarden deployment step out of the
infrascript, so the deployment will just leave the existing service unchanged.Notes
I'm doing this as a PR, but it's already been deployed to staging and the results (at least as far as confirming that big imports now work) were checked by Rebecca, so I'm going to merge it myself.
Testing Instructions
Tested by http://urbanappsci.internal.azavea.com/view/cicero/job/azavea/job/pfb-network-connectivity/job/test%252Frevert-aws-cli/4/
Checklist