-
Notifications
You must be signed in to change notification settings - Fork 387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve unit test coverage of CLI and Runners #1966
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
since it is now included in unit tests
AdeelH
force-pushed
the
runner-unit-tests
branch
2 times, most recently
from
October 19, 2023 15:20
3a623fc
to
0aa3a6a
Compare
AdeelH
force-pushed
the
runner-unit-tests
branch
from
October 19, 2023 16:29
0aa3a6a
to
ca70b22
Compare
Codecov Report
@@ Coverage Diff @@
## master #1966 +/- ##
==========================================
+ Coverage 82.47% 86.18% +3.71%
==========================================
Files 190 191 +1
Lines 9337 9362 +25
==========================================
+ Hits 7701 8069 +368
+ Misses 1636 1293 -343
|
AdeelH
added a commit
to AdeelH/raster-vision
that referenced
this pull request
Apr 10, 2024
AdeelH
added a commit
that referenced
this pull request
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR
tiny_spacenet
exampleRunner
s for clarity.It also removes the steps in the release process that asked for testing the example pipelines, since that is now covered by unit tests.
Checklist
needs-backport
label if PR is bug fix that applies to previous minor releaseNotes
The PR does not add unit tests for submitting jobs via
AWSBatchRunner
, since mocking Batch with all the job queues and job definitions is very non-trivial.Testing Instructions
Closes #1919