Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve unit test coverage of CLI and Runners #1966

Merged
merged 9 commits into from
Oct 19, 2023

Conversation

AdeelH
Copy link
Collaborator

@AdeelH AdeelH commented Oct 18, 2023

Overview

This PR

  • adds unit tests that invoke CLI commands
  • adds a unit test that runs the tiny_spacenet example
  • refactors Runners for clarity.

It also removes the steps in the release process that asked for testing the example pipelines, since that is now covered by unit tests.

Checklist

  • Added needs-backport label if PR is bug fix that applies to previous minor release
  • Ran scripts/format_code and committed any changes
  • Documentation updated if needed
  • PR has a name that won't get you publicly shamed for vagueness

Notes

The PR does not add unit tests for submitting jobs via AWSBatchRunner, since mocking Batch with all the job queues and job definitions is very non-trivial.

Testing Instructions

  • See new unit tests.

Closes #1919

@AdeelH AdeelH force-pushed the runner-unit-tests branch 2 times, most recently from 3a623fc to 0aa3a6a Compare October 19, 2023 15:20
@AdeelH AdeelH force-pushed the runner-unit-tests branch from 0aa3a6a to ca70b22 Compare October 19, 2023 16:29
@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Merging #1966 (ca70b22) into master (e3abaf4) will increase coverage by 3.71%.
The diff coverage is 79.36%.

@@            Coverage Diff             @@
##           master    #1966      +/-   ##
==========================================
+ Coverage   82.47%   86.18%   +3.71%     
==========================================
  Files         190      191       +1     
  Lines        9337     9362      +25     
==========================================
+ Hits         7701     8069     +368     
+ Misses       1636     1293     -343     
Files Coverage Δ
...ervision/pytorch_backend/examples/tiny_spacenet.py 100.00% <100.00%> (ø)
...eline/rastervision/pipeline/runner/local_runner.py 98.30% <97.05%> (+80.30%) ⬆️
rastervision_pipeline/rastervision/pipeline/cli.py 93.68% <50.00%> (+60.35%) ⬆️
...s_batch/rastervision/aws_batch/aws_batch_runner.py 53.12% <58.33%> (+35.73%) ⬆️

... and 20 files with indirect coverage changes

@AdeelH AdeelH marked this pull request as ready for review October 19, 2023 18:06
@AdeelH AdeelH merged commit 7106652 into azavea:master Oct 19, 2023
1 check passed
@AdeelH AdeelH deleted the runner-unit-tests branch October 19, 2023 18:11
AdeelH added a commit to AdeelH/raster-vision that referenced this pull request Apr 10, 2024
AdeelH added a commit that referenced this pull request Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve unit test coverage of CLI and Runners
1 participant