Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QA-2142] test: add coverage in csv #1660

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

rafael-qazion
Copy link
Contributor

@rafael-qazion rafael-qazion commented Aug 30, 2024

Pull Request

What is the new behavior introduced by this PR?

add coverage in csv

Does this PR introduce breaking changes?

  • No
  • Yes

Does this PR introduce UI changes? Add a video or screenshots here.

No

Does it have a link on Figma?

No


Checklist

Make sure your pull request fits the checklist below (when applicable):

  • The issue title follows the format: [ISSUE_CODE] TYPE: TITLE
  • Commits are tagged with the right word (feat, test, refactor, etc)
  • Application responsiveness was tested to different screen sizes
  • Code is formatted and linted
  • Tags are added to the PR

These changes were tested on the following browsers:

  • Chrome
  • Edge
  • Firefox
  • Safari

Copy link
Contributor

@william-tome william-tome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Não me parece que isso deveria estar dentro do console. Com essa adição, estaríamos onerando o usuário em mais uma dependência pra gerar algo interno à empresa.
E se for muito necessário gerar esse report em planilha, acredito que o formato csv atenderia, sem adicionar dependências externas.

vinigfer
vinigfer previously approved these changes Sep 9, 2024
@rafael-qazion rafael-qazion changed the title [QA-2142] test: add coverage in xlsx [QA-2142] test: add coverage in csv Sep 10, 2024
Copy link

sonarcloud bot commented Sep 10, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants