Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added backup in azurerm_cosmosdb_account #2080

Merged
merged 1 commit into from
Nov 11, 2024
Merged

Conversation

hadiulla
Copy link
Contributor

@hadiulla hadiulla commented Nov 1, 2024

2074

PR Checklist


Description

This pull request includes changes to the modules/databases/cosmos_dbs/cosmosdb_account.tf file to add dynamic backup configurations for Cosmos DB accounts.

Key changes:

  • Added a dynamic block for backup configurations in the azurerm_cosmosdb_account resource. This block includes parameters such as type, tier, interval_in_minutes, retention_in_hours, and storage_redundancy, which are conditionally set based on the var.settings.backup variable.
  • Removed unnecessary blank lines at the end of the azurerm_cosmosdb_account resource definition.

Does this introduce a breaking change

  • YES
  • NO

Testing

@arnaudlh arnaudlh requested a review from Copilot November 6, 2024 07:20

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (1)
  • modules/databases/cosmos_dbs/cosmosdb_account.tf: Language not supported

Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon. Learn more

@arnaudlh arnaudlh self-requested a review November 6, 2024 07:20
@arnaudlh arnaudlh assigned arnaudlh and hadiulla and unassigned arnaudlh Nov 6, 2024
@arnaudlh arnaudlh added enhancement New feature or request cosmos labels Nov 6, 2024
@arnaudlh arnaudlh requested a review from Copilot November 11, 2024 02:20

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (1)
  • modules/databases/cosmos_dbs/cosmosdb_account.tf: Language not supported

Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon. Learn more

@arnaudlh arnaudlh linked an issue Nov 11, 2024 that may be closed by this pull request
1 task
Copy link
Member

@arnaudlh arnaudlh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arnaudlh arnaudlh added this to the 5.7.15 milestone Nov 11, 2024
@arnaudlh arnaudlh merged commit 0cdb3ba into aztfmod:main Nov 11, 2024
212 of 213 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cosmos enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Feature request-CosmosDB Backup options is not supported
2 participants