-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support detecting Kafka by analyzing pom.xml and application.yml #18
Conversation
I kept the empty value to override the value in
Are you sure the empty string will make the app start failed? I remember it work well when I test event hubs with mi set and connect string set to empty string. |
Please read this: https://github.com/azure-javaee/azure-dev/wiki/Knowledge-Sharing#2-sometimes-the-environment-variable-not-take-effect-in-spring-boot-application |
Override these properties by environment variable can solve this problem. |
# Conflicts: # cli/azd/internal/repository/infra_confirm.go # cli/azd/internal/scaffold/spec.go
Feature:
pom.xml
andapplication.yaml
azd init
andazd up
.Fix:
Removed connection string configuration when using MI auth, vice versa.Because when using MI, it still firstly try to get connection string (empty string), and failed to parse.
Small fix for connection string configuration:SPRING_CLOUD_AZURE_EVENTHUBS_CONNECTIONSTRING
->SPRING_CLOUD_AZURE_EVENTHUBS_CONNECTION_STRING
.Open issue:
azd init
, we will inject the MI configuration and set the connection string as empty string explicitly. In this case, the configuration does NOT make app running.The root cause is that the empty connection string configuration is also be parsed by azure java SDK, created an issue to track: [BUG] Still use connection string auth even if the connection string property is set as empty string Azure/azure-sdk-for-java#42880
TODO:
application.yaml
, instead of always creating a new one.