Skip to content

Commit

Permalink
Fix review cosmetics
Browse files Browse the repository at this point in the history
  • Loading branch information
baschny committed Nov 29, 2023
1 parent 761fefd commit fe7ba57
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions Classes/Updates/MigrateRealUrlExcludeField.php
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ public function getDescription(): string
return 'Masi - Migrate RealUrl pages.tx_realurl_exclude field to Masi pages.exclude_slug_for_subpages';
}

protected function getExistingExcludedPages()
protected function getExistingExcludedPages(): array
{
$conn = GeneralUtility::makeInstance(ConnectionPool::class)->getConnectionForTable('pages');
$queryBuilder = $conn->createQueryBuilder();
Expand Down Expand Up @@ -100,11 +100,11 @@ protected function doesRealurlFieldExist(): bool

/**
* Upgrade is necessary if the environment has the "tx_realurl_exclude" column and
* there is any page where has this set to "1", else skip the wizard
* there is at least one page having this field set to "1", else skip the wizard
*/
public function updateNecessary(): bool
{
return ($this->doesRealurlFieldExist() && count($this->getExistingExcludedPages()) > 0);
return $this->doesRealurlFieldExist() && count($this->getExistingExcludedPages()) > 0;
}

public function getPrerequisites(): array
Expand Down

0 comments on commit fe7ba57

Please sign in to comment.