Merge pull request #26 from babbel/default-tags

Breaking change: Rename `var.tags` to `var.default_tags`

README.md

@@ -19,10 +19,5 @@ module "nlb" {
     eu-west-1a = cidrsubnet(aws_vpc.this, 8, 0)
     eu-west-1b = cidrsubnet(aws_vpc.this, 8, 1)
   }
-
-  tags = {
-    app = "example"
-    env = "production"
-  }
 }
 ```

_test/main.tf

@@ -14,7 +14,7 @@ module "nlb" {
     local-b = "10.0.1.0/24"
   }
 
-  tags = {
+  default_tags = {
     app = "example"
     env = "production"
   }

main.tf

@@ -10,7 +10,7 @@ module "subnets" {
   availability_zone = each.key
   cidr_block        = each.value
 
-  tags = var.tags
+  default_tags = var.default_tags
 }
 
 # NLB
@@ -23,7 +23,7 @@ resource "aws_lb" "this" {
   internal = true
   subnets  = values(module.subnets)[*].this.id
 
-  tags = var.tags
+  tags = var.default_tags
 }
 
 # API Gateway VPC Link
@@ -32,5 +32,5 @@ resource "aws_api_gateway_vpc_link" "this" {
   name        = var.name
   target_arns = [aws_lb.this.arn]
 
-  tags = var.tags
+  tags = var.default_tags
 }

subnet/main.tf

@@ -8,15 +8,15 @@ resource "aws_subnet" "this" {
 
   tags = merge({
     Name = "private - ${var.name} - ${var.availability_zone}"
-  }, var.tags)
+  }, var.default_tags)
 }
 
 resource "aws_route_table" "this" {
   vpc_id = var.vpc.id
 
   tags = merge({
     Name = "private - ${var.name} - ${var.availability_zone}"
-  }, var.tags)
+  }, var.default_tags)
 }
 
 resource "aws_route_table_association" "this" {

subnet/variables.tf

@@ -14,19 +14,20 @@ Subnet CIDR.
 EOS
 }
 
-variable "name" {
-  type = string
+variable "default_tags" {
+  type    = map(string)
+  default = {}
 
   description = <<EOS
-Name of the NLB.
+Map of tags assigned to all AWS resources created by this module.
 EOS
 }
 
-variable "tags" {
-  type = map(string)
+variable "name" {
+  type = string
 
   description = <<EOS
-Map of tags assigned to all AWS resources created by this module.
+Name of the NLB.
 EOS
 }
 

variables.tf

@@ -6,20 +6,20 @@ Map of subnet CIDRs by availability zone used by the NLB.
 EOS
 }
 
-variable "name" {
-  type = string
+variable "default_tags" {
+  type    = map(string)
+  default = {}
 
   description = <<EOS
-Name of the NLB.
+Map of tags assigned to all AWS resources created by this module.
 EOS
 }
 
-variable "tags" {
-  type    = map(string)
-  default = {}
+variable "name" {
+  type = string
 
   description = <<EOS
-Map of tags assigned to all AWS resources created by this module.
+Name of the NLB.
 EOS
 }