Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump action versions and update docs workflow trigger #129

Merged
merged 4 commits into from
Dec 16, 2024
Merged

Conversation

jessicasyu
Copy link
Member

Housekeeping on some workflow action versions:

  • Unpin ruby/setup-ruby (which should fix the current failing docs job on main)
  • Bump mikepenz/release-changelog-builder-action to v5.0.0
  • Fix trigger for docs badges job to always run (currently skipped if a previous job fails)
    • This should correctly generate a "failing" docs badge
    • Same strategy is used in the build and lint badge jobs
  • Add trigger for docs workflow to also run when a release is published
    • This should re-trigger docs after the release workflow finished to update versions in the docs

@jessicasyu jessicasyu added type: admin Management of project or repository size: xsmall Estimated size of issue or PR is xsmall labels Dec 13, 2024
@jessicasyu jessicasyu requested review from a team December 13, 2024 17:11
@Jannetty
Copy link
Member

@jessicasyu is there a way for us to test/verify this locally? All my experiences testing github actions workflows requires just running them a ton, which is not surely advisable for a release workflow. This all looks good and makes sense to me but I have not run it.

@jessicasyu
Copy link
Member Author

@Jannetty I don't have a great answer unfortunately. I usually use a personal "sandbox" repo to test actions when making big changes. For small changes like this, as long as the changes make sense and don't have any glaring syntax errors, I think the easiest is just to try and see what happens.

@jessicasyu jessicasyu requested review from a team, jacob-evarts, allison-li-1016, Jannetty, pohaoc2 and daniellevahdat and removed request for a team December 13, 2024 22:31
@cainja
Copy link
Member

cainja commented Dec 13, 2024

Just to add to this thread, I think most of the ways to "test" github CI is kind of clunky and unnecessary for our purposes - i.e. we're not deploying CI/CD to production so I'm okay with it passing a gut check as long as the people who ultimately merge are paying attention.

@jessicasyu jessicasyu merged commit 2033e4e into main Dec 16, 2024
6 checks passed
@jessicasyu jessicasyu deleted the fix/bump-ruby branch December 16, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: xsmall Estimated size of issue or PR is xsmall type: admin Management of project or repository
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants