Fix GraphEdit port snapping in certain edge cases

baiduwen3 · Aug 2, 2024 · 1f0eddc · 1f0eddc
1 parent 3978628
commit 1f0eddc
Showing 1 changed file with 7 additions and 7 deletions.
diff --git a/scene/gui/graph_edit.cpp b/scene/gui/graph_edit.cpp
@@ -912,7 +912,7 @@ bool GraphEdit::_filter_input(const Point2 &p_point) {
 
 		// This prevents interactions with a port hotzone that is behind another node.
 		Rect2 graph_node_rect = Rect2(graph_node->get_position(), graph_node->get_size() * zoom);
-		if (graph_node_rect.has_point(click_pos * zoom)) {
+		if (graph_node_rect.has_point(p_point)) {
 			break;
 		}
 	}
@@ -1044,12 +1044,6 @@ void GraphEdit::_top_connection_layer_input(const Ref<InputEvent> &p_ev) {
 					return;
 				}
 			}
-
-			// This prevents interactions with a port hotzone that is behind another node.
-			Rect2 graph_node_rect = Rect2(graph_node->get_position(), graph_node->get_size() * zoom);
-			if (graph_node_rect.has_point(click_pos * zoom)) {
-				break;
-			}
 		}
 	}
 
@@ -1121,6 +1115,12 @@ void GraphEdit::_top_connection_layer_input(const Ref<InputEvent> &p_ev) {
 					}
 					connecting_target_valid = false;
 				}
+
+				// This prevents interactions with a port hotzone that is behind another node.
+				Rect2 graph_node_rect = Rect2(graph_node->get_position(), graph_node->get_size() * zoom);
+				if (graph_node_rect.has_point(mm->get_position())) {
+					break;
+				}
 			}
 		}
 	}